Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 483793002: Don't disable -Wabsolute-value when building for arm. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't disable -Wabsolute-value when building for arm. The things requiring this have been fixed. BUG=395832 TBR=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290396

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/common.gypi View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
6 years, 4 months ago (2014-08-18 16:20:15 UTC) #1
Nico
(I changed this to be just about the -Wno-absolute-value change, since that required pdfium changes ...
6 years, 4 months ago (2014-08-18 19:55:38 UTC) #2
Nico
Committed patchset #3 manually as 290396 (presubmit successful).
6 years, 4 months ago (2014-08-18 23:12:39 UTC) #3
Sam Clegg
6 years, 4 months ago (2014-08-19 08:51:46 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698