Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: build/common.gypi

Issue 483793002: Don't disable -Wabsolute-value when building for arm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3703 matching lines...) Expand 10 before | Expand all | Expand 10 after
3714 # The codesourcery arm-2009q3 toolchain warns at that the ABI 3714 # The codesourcery arm-2009q3 toolchain warns at that the ABI
3715 # has changed whenever it encounters a varargs function. T his 3715 # has changed whenever it encounters a varargs function. T his
3716 # silences those warnings, as they are not helpful and 3716 # silences those warnings, as they are not helpful and
3717 # clutter legitimate warnings. 3717 # clutter legitimate warnings.
3718 '-Wno-abi', 3718 '-Wno-abi',
3719 ], 3719 ],
3720 }], 3720 }],
3721 ['clang==1 and arm_arch!="" and OS!="android"', { 3721 ['clang==1 and arm_arch!="" and OS!="android"', {
3722 'cflags': [ 3722 'cflags': [
3723 '-target arm-linux-gnueabihf', 3723 '-target arm-linux-gnueabihf',
3724 # TODO(sbc): Remove this once the warning in libvpx is fix ed:
3725 # https://code.google.com/p/webm/issues/detail?id=829
3726 '-Wno-absolute-value',
3727 ], 3724 ],
3728 'ldflags': [ 3725 'ldflags': [
3729 '-target arm-linux-gnueabihf', 3726 '-target arm-linux-gnueabihf',
3730 ], 3727 ],
3731 }], 3728 }],
3732 ['arm_arch!=""', { 3729 ['arm_arch!=""', {
3733 'cflags': [ 3730 'cflags': [
3734 '-march=<(arm_arch)', 3731 '-march=<(arm_arch)',
3735 ], 3732 ],
3736 }], 3733 }],
(...skipping 1946 matching lines...) Expand 10 before | Expand all | Expand 10 after
5683 # settings in target dicts. SYMROOT is a special case, because many other 5680 # settings in target dicts. SYMROOT is a special case, because many other
5684 # Xcode variables depend on it, including variables such as 5681 # Xcode variables depend on it, including variables such as
5685 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5682 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5686 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5683 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5687 # files to appear (when present) in the UI as actual files and not red 5684 # files to appear (when present) in the UI as actual files and not red
5688 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5685 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5689 # and therefore SYMROOT, needs to be set at the project level. 5686 # and therefore SYMROOT, needs to be set at the project level.
5690 'SYMROOT': '<(DEPTH)/xcodebuild', 5687 'SYMROOT': '<(DEPTH)/xcodebuild',
5691 }, 5688 },
5692 } 5689 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698