PlzNavigate: implement CommitNavigation on the browser side

content/browser/frame_host/navigation_request_info.h

Index: content/browser/frame_host/navigation_request_info.h
diff --git a/content/browser/frame_host/navigation_request_info.h b/content/browser/frame_host/navigation_request_info.h
index 4342863187f19adbdbd09e942843f0f4f77eb437..0876ed56151f35d617aaa5feb8b3bc29f8d57b3d 100644
--- a/content/browser/frame_host/navigation_request_info.h
+++ b/content/browser/frame_host/navigation_request_info.h
@@ -9,6 +9,7 @@
 
 #include "base/basictypes.h"
 #include "content/common/frame_messages.h"
+#include "content/common/navigation_params.h"
 #include "content/public/common/page_transition_types.h"
 #include "content/public/common/referrer.h"
 #include "url/gurl.h"
@@ -19,8 +20,10 @@ namespace content {
 // ResourceDispatcherHost. It is initialized on the UI thread, and then passed
 // to the IO thread by a NavigationRequest object.
 struct NavigationRequestInfo {
-  NavigationRequestInfo(const FrameHostMsg_BeginNavigation_Params& params);
+  NavigationRequestInfo(const CoreNavigationParams& core_params,
+                        const FrameHostMsg_BeginNavigation_Params& params);
 
+  const CoreNavigationParams core_params;
   const FrameHostMsg_BeginNavigation_Params navigation_params;
 
   // ---------------------------------------------------------------------------
@@ -32,6 +35,9 @@ struct NavigationRequestInfo {
   GURL first_party_for_cookies;
   bool is_main_frame;
   bool parent_is_main_frame;
+
+  // Whether or not we should allow the URL to download (true by default).

[Charlie Reis, 2014/09/19 23:12:31]

Ah, I see the point of confusion now.  This description (which was copied from
existing code) makes it sounds like we already know it's a download, and that
the bool indicates whether it should be permitted.  Instead, it's about whether
future downloads of the URL are allowed.

Can we rephrase it to this?

// Whether or not we should allow this URL to be downloaded (true by default).

+  bool allow_download;

[Charlie Reis, 2014/09/19 23:12:31]

I still don't follow why this was moved from FrameHostMsg_BeginNavigation_Params
to here.  Is there a plan to move more of those params to here, or is this one
different?

[clamy, 2014/09/23 21:13:25]

Ah it got lost in the moving of parameters. It is now part of CoreParams (and
provided by the browser). Ideally  I think FrameHostMsg_BeginNavigation_Params
should have as few parameters as is necessary, as it is coming from the
renderer, which may have been compromised.

 };
 
 }  // namespace content