PlzNavigate: implement CommitNavigation on the browser side

content/browser/frame_host/navigation_request_info.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_INFO_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_INFO_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "content/common/frame_messages.h"
+#include "content/common/navigation_params.h"
 #include "content/public/common/page_transition_types.h"
 #include "content/public/common/referrer.h"
 #include "url/gurl.h"
 
 namespace content {
 
 // A struct to hold the parameters needed to start a navigation request in
 // ResourceDispatcherHost. It is initialized on the UI thread, and then passed
 // to the IO thread by a NavigationRequest object.
 struct NavigationRequestInfo {
-  NavigationRequestInfo(const FrameHostMsg_BeginNavigation_Params& params);
+  NavigationRequestInfo(const CoreNavigationParams& core_params,
+                        const FrameHostMsg_BeginNavigation_Params& params);
 
+  const CoreNavigationParams core_params;
   const FrameHostMsg_BeginNavigation_Params navigation_params;
 
   // ---------------------------------------------------------------------------
   // The following parameters should be filled in by RenderFrameHostManager
   // before the navigation request is sent to the ResourceDispatcherHost.
 
   // Usually the URL of the document in the top-level window, which may be
   // checked by the third-party cookie blocking policy.
   GURL first_party_for_cookies;
   bool is_main_frame;
   bool parent_is_main_frame;
+
+  // Whether or not we should allow the URL to download (true by default).

[Charlie Reis, 2014/09/19 23:12:31]

Ah, I see the point of confusion now.  This description (which was copied from
existing code) makes it sounds like we already know it's a download, and that
the bool indicates whether it should be permitted.  Instead, it's about whether
future downloads of the URL are allowed.

Can we rephrase it to this?

// Whether or not we should allow this URL to be downloaded (true by default).

+  bool allow_download;

[Charlie Reis, 2014/09/19 23:12:31]

I still don't follow why this was moved from FrameHostMsg_BeginNavigation_Params
to here.  Is there a plan to move more of those params to here, or is this one
different?

[clamy, 2014/09/23 21:13:25]

Ah it got lost in the moving of parameters. It is now part of CoreParams (and
provided by the browser). Ideally  I think FrameHostMsg_BeginNavigation_Params
should have as few parameters as is necessary, as it is coming from the
renderer, which may have been compromised.

 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_INFO_H_