Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 483633002: Add toFloat*Array() methods and use them in layout tests. (Closed)

Created:
6 years, 4 months ago by zino
Modified:
6 years, 4 months ago
Reviewers:
krit, Rik
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add toFloat*Array() methods and use them in layout tests. The methods return the serialized 16 elements m11 to m44 of the current matrix in column-major order. The specification: http://dev.w3.org/fxtf/geometry/ Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V_bJNtOg0oM BUG=388780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180827

Patch Set 1 #

Patch Set 2 : TestExepectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -69 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html View 1 chunk +33 lines, -41 lines 0 comments Download
M LayoutTests/fast/dom/geometry-interfaces-dom-matrix-translate.html View 4 chunks +20 lines, -28 lines 0 comments Download
M Source/core/dom/DOMMatrixReadOnly.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/dom/DOMMatrixReadOnly.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M Source/core/dom/DOMMatrixReadOnly.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
zino
PTAL
6 years, 4 months ago (2014-08-18 05:07:28 UTC) #1
Rik
lgtm
6 years, 4 months ago (2014-08-22 09:09:54 UTC) #2
krit
lgtm
6 years, 4 months ago (2014-08-22 09:26:09 UTC) #3
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 4 months ago (2014-08-24 05:59:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/483633002/20001
6 years, 4 months ago (2014-08-24 06:00:13 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-24 06:49:46 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-24 06:51:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/13583)
6 years, 4 months ago (2014-08-24 06:51:46 UTC) #8
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 4 months ago (2014-08-24 06:54:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/483633002/20001
6 years, 4 months ago (2014-08-24 06:55:23 UTC) #10
zino
The CQ bit was unchecked by jinho.bang@samsung.com
6 years, 4 months ago (2014-08-24 06:58:04 UTC) #11
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 4 months ago (2014-08-24 06:58:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/483633002/20001
6 years, 4 months ago (2014-08-24 06:58:15 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-24 07:58:05 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-24 08:32:43 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180827

Powered by Google App Engine
This is Rietveld 408576698