Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 483443002: Revert 290001 because it's causing test failures: (Closed)

Created:
6 years, 4 months ago by sadrul
Modified:
6 years, 4 months ago
Reviewers:
evy
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 290001 because it's causing test failures: [20526:20526:0815/151613:1174431576:FATAL:touch_exploration_controller.cc(763)] Check failed: false. tap timer fired in unrecognized state: CORNER_PASSTHROUGH #0 0x7f485532361e base::debug::StackTrace::StackTrace() #1 0x7f48553ba882 logging::LogMessage::~LogMessage() #2 0x7f485314bcfc ui::TouchExplorationController::OnTapTimerFired() #3 0x7f485314af2b ui::TouchExplorationController::RewriteEvent() #4 0x7f48531c89a6 ui::EventSource::SendEventToProcessor() #5 0x0000005f6bc0 ui::EventSourceTestApi::SendEventToProcessor() #6 0x0000005f396f ui::test::EventGenerator::DoDispatchEvent() #7 0x0000005f1480 ui::test::EventGenerator::Dispatch() #8 0x00000051a1a5 ui::TouchExplorationTest::AssertCornerPassthroughWorking() #9 0x0000005153fb ui::TouchExplorationTest_ActivateLeftCornerPassthrough_Test::TestBody() #10 0x0000005a49f3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #11 0x00000059005e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #12 0x000000583ed5 testing::Test::Run() #13 0x0000005845db testing::TestInfo::Run() In ActivateLeftCornerPassthrough, ActivateRightCornerPassthrough, and SingleTapLongPress tests. > Modified state flow for touch explore released in touch_exploration_controller. > > Now when performing single tap, the tap timer to begin one finger passthrough is not started. This problem originally arose because touch explore released state and single tap released state are treated similarly in the code, but one finger passthrough should be a state reachable only from single tap released. > > Another state change is that if the user presses in single tap/touch explore released and there is no previous touch exploration location, the user is redirected to the wait state. > > TEST=TouchExplorationTest.SingleTapLongPress > BUG=402544 > > Review URL: https://codereview.chromium.org/465543003 TBR=evy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -158 lines) Patch
M trunk/src/ui/chromeos/touch_exploration_controller.h View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/ui/chromeos/touch_exploration_controller.cc View 7 chunks +44 lines, -98 lines 0 comments Download
M trunk/src/ui/chromeos/touch_exploration_controller_unittest.cc View 3 chunks +2 lines, -57 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
6 years, 4 months ago (2014-08-16 05:39:44 UTC) #1
sadrul
6 years, 4 months ago (2014-08-16 05:41:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r290092.

Powered by Google App Engine
This is Rietveld 408576698