Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 483273003: remove unused SkIntToFloatCast_NoOverflowCheck (Closed)

Created:
6 years, 4 months ago by caryclark
Modified:
6 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remove unused SkIntToFloatCast_NoOverflowCheck R=reed BUG=skia:2849 Committed: https://skia.googlesource.com/skia/+/38dd9f2e41748953f46e5daaf341971a851b247d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M include/core/SkFloatBits.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkFloatBits.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M tests/MathTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caryclark
6 years, 4 months ago (2014-08-19 14:08:19 UTC) #1
reed1
lgtm
6 years, 4 months ago (2014-08-19 14:24:40 UTC) #2
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 4 months ago (2014-08-19 14:30:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/483273003/1
6 years, 4 months ago (2014-08-19 14:31:59 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 14:39:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 38dd9f2e41748953f46e5daaf341971a851b247d

Powered by Google App Engine
This is Rietveld 408576698