Incoming references service request and UI.

Incoming references service request and UI.

Misses references from stack frames and embedder handles.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39534

[koda, 2014-08-21 18:21:21]

Nice.

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart
(right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart:16:
bool get slotIsNum => slot is num;
Consider something more descriptive, like "array index" or "element index".

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.html
(right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.html:22:
<template if="{{ slotIsNum }}">via [{{ slot }}]</template>
Ditto; consider using whatever description the retaining path uses.

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:1046: String
toString() => "Isolate($_id)";
Thanks for adding these; I've missed them in the past.

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/object_graph.cc
File runtime/vm/object_graph.cc (right):

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/object_graph...
runtime/vm/object_graph.cc:313: : ObjectVisitor(isolate),
ObjectPointerVisitor(isolate), source_(0),
I think we usually use NULL rather than 0.

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/object_graph...
runtime/vm/object_graph.cc:368: // To break the trivial path, the handle 'obj'
is temporarily cleared during
Is this needed here? You don't seem to look at handles, just pointers from other
heap objects, so this trivial path should not impact your computation. (I guess
it will if you start iterating over the handles too. An alternative would then
be to filter this one out.)

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/object_graph.h
File runtime/vm/object_graph.h (right):

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/object_graph...
runtime/vm/object_graph.h:90: intptr_t InboundReferences(Object* obj, const
Array& path);
Rename 'path'.

[Cutch, 2014-08-21 20:08:56]

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/elements/class_ref.html (right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/elements/class_ref.html:6: <span><a
on-click="{{ goto }}" title="{{ hoverText }}" href="{{ url }}">{{ name
}}</a></span>
Please remove the new lines here.

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart
(right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart:16:
bool get slotIsNum => slot is num;
On 2014/08/21 18:21:20, koda wrote:
> Consider something more descriptive, like "array index" or "element index".

slotIsListIndex

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart
(right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart:61:
@CustomTag('service-ref-downcast')
Rename service-ref to be service-ref-common or service-ref-base and rename this
to be service-ref.

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/service.cc#n...
runtime/vm/service.cc:1140: return true;
Did you not need to add 'inbound_references' to other things like code?

[Cutch, 2014-08-21 20:08:56]

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/elements/class_ref.html (right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/elements/class_ref.html:6: <span><a
on-click="{{ goto }}" title="{{ hoverText }}" href="{{ url }}">{{ name
}}</a></span>
Please remove the new lines here.

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart
(right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart:16:
bool get slotIsNum => slot is num;
On 2014/08/21 18:21:20, koda wrote:
> Consider something more descriptive, like "array index" or "element index".

slotIsListIndex

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart
(right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart:61:
@CustomTag('service-ref-downcast')
Rename service-ref to be service-ref-common or service-ref-base and rename this
to be service-ref.

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/service.cc#n...
runtime/vm/service.cc:1140: return true;
Did you not need to add 'inbound_references' to other things like code?

[rmacnak, 2014-08-21 22:06:45]

Also made retaining path use any-service-ref so Functions/Code/Fields in the
path are proper links.

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/elements/class_ref.html (right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/elements/class_ref.html:6: <span><a
on-click="{{ goto }}" title="{{ hoverText }}" href="{{ url }}">{{ name
}}</a></span>
On 2014/08/21 20:08:55, Cutch wrote:
> Please remove the new lines here.

Pretty printed to match the other short foo-refs.

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.html
(right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.html:22:
<template if="{{ slotIsNum }}">via [{{ slot }}]</template>
On 2014/08/21 18:21:20, koda wrote:
> Ditto; consider using whatever description the retaining path uses.

Changed retaining path to "in [2] of". This way they both look like the language
expression to access the slot.

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/object_graph.cc
File runtime/vm/object_graph.cc (right):

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/object_graph...
runtime/vm/object_graph.cc:368: // To break the trivial path, the handle 'obj'
is temporarily cleared during
On 2014/08/21 18:21:20, koda wrote:
> Is this needed here? You don't seem to look at handles, just pointers from
other
> heap objects, so this trivial path should not impact your computation. (I
guess
> it will if you start iterating over the handles too. An alternative would then
> be to filter this one out.)

True; removed.

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/483103003/diff/120001/runtime/vm/service.cc#n...
runtime/vm/service.cc:1140: return true;
On 2014/08/21 20:08:56, Cutch wrote:
> Did you not need to add 'inbound_references' to other things like code?

Currently it will just fail if you try to chase past non-instances and the UI
will give an empty result. I'd rather not sprinkle this all over the handlers in
this CL.

[rmacnak, 2014-08-25 21:46:36]

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
File runtime/bin/vmservice/observatory/lib/src/elements/class_ref.html (right):

https://codereview.chromium.org/483103003/diff/120001/runtime/bin/vmservice/o...
runtime/bin/vmservice/observatory/lib/src/elements/class_ref.html:6: <span><a
on-click="{{ goto }}" title="{{ hoverText }}" href="{{ url }}">{{ name
}}</a></span>
On 2014/08/21 22:06:44, rmacnak wrote:
> On 2014/08/21 20:08:55, Cutch wrote:
> > Please remove the new lines here.
> 
> Pretty printed to match the other short foo-refs.

Removed new lines.

[Cutch, 2014-08-25 21:47:50]

lgtm

[rmacnak, 2014-08-25 22:32:03]

Committed patchset #9 manually as 39534 (presubmit successful).