Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: runtime/bin/vmservice/observatory/lib/src/service/object.dart

Issue 483103003: Incoming references service request and UI. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/observatory/lib/src/service/object.dart
diff --git a/runtime/bin/vmservice/observatory/lib/src/service/object.dart b/runtime/bin/vmservice/observatory/lib/src/service/object.dart
index 6dd19adf09ebef9b8e67faa518226eba18863f1e..a4cbe2c738205ff4a8ba023f84b9b1aef76d8490 100644
--- a/runtime/bin/vmservice/observatory/lib/src/service/object.dart
+++ b/runtime/bin/vmservice/observatory/lib/src/service/object.dart
@@ -1042,6 +1042,8 @@ class Isolate extends ServiceObjectOwner with Coverage {
return isolate.reload();
});
}
+
+ String toString() => "Isolate($_id)";
}
/// A [ServiceObject] which implements [ObservableMap].
@@ -1059,8 +1061,6 @@ class ServiceMap extends ServiceObject implements ObservableMap {
ServiceMap._empty(ServiceObjectOwner owner) : super._empty(owner);
- String toString() => _map.toString();
-
void _upgradeValues() {
assert(owner != null);
_upgradeCollection(_map, owner);
@@ -1105,6 +1105,8 @@ class ServiceMap extends ServiceObject implements ObservableMap {
void unobserved() => _map.unobserved();
Stream<List<ChangeRecord>> get changes => _map.changes;
bool get hasObservers => _map.hasObservers;
+
+ String toString() => "ServiceMap($_map)";
}
/// A [DartError] is peered to a Dart Error object.
@@ -1124,6 +1126,8 @@ class DartError extends ServiceObject {
name = 'DartError $kind';
vmName = name;
}
+
+ String toString() => 'DartError($message)';
}
/// A [ServiceError] is an error that was triggered in the service
@@ -1143,6 +1147,8 @@ class ServiceError extends ServiceObject {
name = 'ServiceError $kind';
vmName = name;
}
+
+ String toString() => 'ServiceError($message)';
}
/// A [ServiceException] is an exception that was triggered in the service
@@ -1189,7 +1195,7 @@ class ServiceEvent extends ServiceObject {
data = map['_data'];
}
}
-
+
String toString() {
return 'ServiceEvent of type $eventType with '
'${data == null ? 0 : data.lengthInBytes} bytes of binary data';
@@ -1241,6 +1247,8 @@ class Library extends ServiceObject with Coverage {
functions.addAll(map['functions']);
functions.sort(ServiceObject.LexicalSortName);
}
+
+ String toString() => "Library($url)";
}
class AllocationCount extends Observable {
@@ -1312,10 +1320,6 @@ class Class extends ServiceObject with Coverage {
Class._empty(ServiceObjectOwner owner) : super._empty(owner);
- String toString() {
- return 'Service Class: $vmName';
- }
-
void _update(ObservableMap map, bool mapIsRef) {
name = map['name'];
vmName = (map.containsKey('vmName') ? map['vmName'] : name);
@@ -1387,6 +1391,8 @@ class Class extends ServiceObject with Coverage {
Future<ServiceObject> get(String command) {
return isolate.get(id + "/$command");
}
+
+ String toString() => 'Class($vmName)';
}
// TODO(koda): Sync this with VM.

Powered by Google App Engine
This is Rietveld 408576698