[Athena] Add status icons and system time to the centered home card

[Athena] Add status icons and system time to the centered home card

BUG=404156
TEST=Manual, see bug

Committed: https://crrev.com/9c8d49620ce27bd5a47ced8ca211944d375c8ebf
Cr-Commit-Position: refs/heads/master@{#293042}

[pkotwicz, 2014-08-19 03:26:36]

Sadrul, PTAL

This CL breaks clicking on the status icons in overview mode but not in the home
card. I want to fix that in a separate CL though.

There is now a maximum number of status icons because the status icons (as
specified in the mocks) are below the windows that the user can move
around in overview mode. So it is possible to have status icons occluded by
windows in overview mode.

I considered having SystemUI return views::Widgets for the time and the status
icons but returning a views::View seems to make more sense

I introduced a number of new header files which is non-athena-like. Having as
much stuff in an anonymous namespace as we do now makes code virtually
untestable. (e.g. if you wanted to test the home card code)

[sadrul, 2014-08-19 16:11:11]

A few comments:
 . BackgroundController probably still fits in athena/screen/ better than in
athena/system/. Why not use the SystemUI interface to get the appropriate views
and add them from the background-controller, without moving BC?

 . Let's split this patch into smaller patches: (1) Move main/debug/ into
system/, use it for overview (2) Add the code for color scheme, use it in home
card.

[pkotwicz, 2014-09-02 03:48:24]

Sadrul, can you please take a look?

This CL is now based off of https://codereview.chromium.org/483363003 which has
landed

[sadrul, 2014-09-02 15:11:13]

sadrul@chromium.org changed reviewers:
+ mukai@chromium.org

[sadrul, 2014-09-02 15:11:14]

+mukai@

https://codereview.chromium.org/483033003/diff/120001/athena/home/athena_star...
File athena/home/athena_start_page_view.cc (right):

https://codereview.chromium.org/483033003/diff/120001/athena/home/athena_star...
athena/home/athena_start_page_view.cc:179: // looks bad. |time_view_|'s
background animating at a different rate than
I think you can set some attrib on the Label so the text looks OK on a
transparent layer (iirc we use it for the ash-tray texts).

https://codereview.chromium.org/483033003/diff/120001/athena/home/athena_star...
File athena/home/athena_start_page_view.h (right):

https://codereview.chromium.org/483033003/diff/120001/athena/home/athena_star...
athena/home/athena_start_page_view.h:82: views::View* status_icon_view_;
Instead of having these two separate items, can there be a single system_view_
that we get from SystemUI? That way, we don't have to update in two places if we
want to change what we show at the top.

[Jun Mukai, 2014-09-02 17:00:58]

https://codereview.chromium.org/483033003/diff/120001/athena/home/athena_star...
File athena/home/athena_start_page_view.h (right):

https://codereview.chromium.org/483033003/diff/120001/athena/home/athena_star...
athena/home/athena_start_page_view.h:82: views::View* status_icon_view_;
On 2014/09/02 15:11:14, sadrul wrote:
> Instead of having these two separate items, can there be a single system_view_
> that we get from SystemUI? That way, we don't have to update in two places if
we
> want to change what we show at the top.

+1

[pkotwicz, 2014-09-02 19:47:49]

Sadrul and Mukai can you please take another look?

https://codereview.chromium.org/483033003/diff/120001/athena/home/athena_star...
File athena/home/athena_start_page_view.cc (right):

https://codereview.chromium.org/483033003/diff/120001/athena/home/athena_star...
athena/home/athena_start_page_view.cc:179: // looks bad. |time_view_|'s
background animating at a different rate than
Disabling subpixel rendering does the trick. Thanks for making me look.

https://codereview.chromium.org/483033003/diff/120001/athena/home/athena_star...
File athena/home/athena_start_page_view.h (right):

https://codereview.chromium.org/483033003/diff/120001/athena/home/athena_star...
athena/home/athena_start_page_view.h:82: views::View* status_icon_view_;
On 2014/09/02 15:11:14, sadrul wrote:
> Instead of having these two separate items, can there be a single system_view_
> that we get from SystemUI? That way, we don't have to update in two places if
we
> want to change what we show at the top.

Done.

[sadrul, 2014-09-02 19:55:11]

Thanks! LGTM

[Jun Mukai, 2014-09-02 19:58:39]

lgtm

[pkotwicz, 2014-09-02 20:28:55]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-09-02 20:29:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/483033003/140001

[commit-bot: I haz the power, 2014-09-02 21:27:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-09-02 21:51:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-02 21:51:46]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2014-09-02 23:19:57]

mukai@, can you please take another look?

I have made AthenaStartPageViewTest inherit from AthenaTestBase.

AthenaStartPageView now needs athena::SystemUI existing which depends on
athena::ScreenManager existing

[Jun Mukai, 2014-09-02 23:22:17]

still lgtm

[pkotwicz, 2014-09-02 23:58:09]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-09-03 00:03:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/483033003/160001

[commit-bot: I haz the power, 2014-09-03 01:39:04]

Committed patchset #5 (id:160001) as 8093a74da3e31cdda1d6cb520956b8a43d8794cf

[commit-bot: I haz the power, 2014-09-10 03:22:36]

Patchset 5 (id:??) landed as
https://crrev.com/9c8d49620ce27bd5a47ced8ca211944d375c8ebf
Cr-Commit-Position: refs/heads/master@{#293042}