[Athena] Add status icons and system time to the desktop background

[Athena] Add status icons and system time to the desktop background

BUG=404156
TEST=Manual, see bug
TBR=sadrul, oshima (TBRing because of DEPS file modifications)

Committed: https://crrev.com/73bd924d3996da6e1992b095e3eca90e29c0a10d
Cr-Commit-Position: refs/heads/master@{#292895}

[pkotwicz, 2014-08-19 20:45:07]

Sadrul, can you please take another look?

As with the previous CL you looked at touching / clicking on the status icons
does not work. I will fix that in a separate CL

We will need some way of getting the same popup container in the
BackgroundController code and in the HomeCardImpl code.

We will probably need to be able to query ScreenManager for a particular
container (Similar to how it is possible to do so on Ash)

[pkotwicz, 2014-08-19 20:51:19]

Introducing an "always on top" container and parenting windows to it based on
the views::Widget::InitParams::keep_on_top parameter might be helpful

[pkotwicz, 2014-08-21 14:54:18]

Ping?

[sadrul, 2014-08-21 18:44:30]

LGTM

https://codereview.chromium.org/483363003/diff/20001/athena/common/container_...
File athena/common/container_priorities.h (right):

https://codereview.chromium.org/483363003/diff/20001/athena/common/container_...
athena/common/container_priorities.h:14: CP_POPUP,
Maybe SYSTEM_MODAL instead.

https://codereview.chromium.org/483363003/diff/20001/athena/system/status_ico...
File athena/system/status_icon_container_view.cc (left):

https://codereview.chromium.org/483363003/diff/20001/athena/system/status_ico...
athena/system/status_icon_container_view.cc:140: closure_.Run();
This was necessary to make sure the widget and the network list is sized
correctly. Can you make sure it works correctly after this change?

https://codereview.chromium.org/483363003/diff/20001/athena/system/system_ui_...
File athena/system/system_ui_impl.cc (right):

https://codereview.chromium.org/483363003/diff/20001/athena/system/system_ui_...
athena/system/system_ui_impl.cc:52: return instance;
DCHECK(instance) (that would be consistent with the other athena modules)

https://codereview.chromium.org/483363003/diff/20001/athena/system/time_view.h
File athena/system/time_view.h (right):

https://codereview.chromium.org/483363003/diff/20001/athena/system/time_view....
athena/system/time_view.h:23: void SetTimer(const base::Time& now);
You don't need to use a const-ref for base::Time

https://codereview.chromium.org/483363003/diff/20001/athena/system/time_view....
athena/system/time_view.h:28: base::OneShotTimer<TimeView> timer_;
DISALLOW_...

[pkotwicz, 2014-08-21 21:57:16]

Oshima for OWNERS

https://codereview.chromium.org/483363003/diff/20001/athena/system/status_ico...
File athena/system/status_icon_container_view.cc (left):

https://codereview.chromium.org/483363003/diff/20001/athena/system/status_ico...
athena/system/status_icon_container_view.cc:140: closure_.Run();
Yes I checked

[oshima, 2014-08-21 23:08:50]

can you move background code to system, instead of
making screen depend on system?

I think backgrounds needs to be its own module eventually but
system is fine for now.

[pkotwicz, 2014-08-22 00:37:19]

Moved BackgroundController into athena/system. Oshima, can you please take
another look?

[oshima, 2014-08-22 14:12:09]

https://codereview.chromium.org/483363003/diff/160001/athena/system/backgroun...
File athena/system/background_controller.cc (right):

https://codereview.chromium.org/483363003/diff/160001/athena/system/backgroun...
athena/system/background_controller.cc:20: :
time_view_(SystemUI::Get()->CreateTimeView()),
Since you're in the same module, you can just create these views without going
through SystemUI?

[pkotwicz, 2014-08-22 14:18:06]

https://codereview.chromium.org/483363003/diff/160001/athena/system/backgroun...
File athena/system/background_controller.cc (right):

https://codereview.chromium.org/483363003/diff/160001/athena/system/backgroun...
athena/system/background_controller.cc:20: :
time_view_(SystemUI::Get()->CreateTimeView()),
SystemUI::CreateTimeView() and SystemUI::CreateStateIconView() will be needed in
order to create these views from the home card.

Using the SystemUI methods here is helpful because the system modal container
does not need to be passed into BackgroundController.

[oshima, 2014-08-22 16:33:55]

https://codereview.chromium.org/483363003/diff/160001/athena/system/backgroun...
File athena/system/background_controller.cc (right):

https://codereview.chromium.org/483363003/diff/160001/athena/system/backgroun...
athena/system/background_controller.cc:20: :
time_view_(SystemUI::Get()->CreateTimeView()),
On 2014/08/22 14:18:06, pkotwicz wrote:
> SystemUI::CreateTimeView() and SystemUI::CreateStateIconView() will be needed
in
> order to create these views from the home card.
> 
> Using the SystemUI methods here is helpful because the system modal container
> does not need to be passed into BackgroundController.
So we're going to have the same UI on background and home card?
Or one in background is temporary?

[pkotwicz, 2014-08-22 16:52:32]

According to the mocks we will have the same UI on both the background and the
home card

[oshima, 2014-08-22 17:13:13]

got it, thanks. lgtm

[pkotwicz, 2014-08-29 14:09:47]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-08-29 14:10:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/483363003/180001

[commit-bot: I haz the power, 2014-08-29 14:21:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/48130)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/53460)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-29 14:23:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-29 14:23:21]

Try jobs failed on following builders:
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)

[pkotwicz, 2014-08-29 17:03:58]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-08-29 17:04:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/483363003/200001

[pkotwicz, 2014-08-29 17:30:16]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-08-29 17:31:05]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-08-29 17:31:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/483363003/200001

[commit-bot: I haz the power, 2014-08-29 18:16:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pkotwicz, 2014-08-29 18:44:02]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-08-29 19:00:02]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-08-29 19:01:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/483363003/220001

[commit-bot: I haz the power, 2014-08-29 22:02:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-29 22:02:53]

Failed to apply patch for athena/main/athena_main.gyp:
While running git apply --index -p1;
  error: patch failed: athena/main/athena_main.gyp:39
  error: athena/main/athena_main.gyp: patch does not apply

Patch:       athena/main/athena_main.gyp
Index: athena/main/athena_main.gyp
diff --git a/athena/main/athena_main.gyp b/athena/main/athena_main.gyp
index
4e86d2b7f52d82576b6c0fb98b7cb9f921edf019..543558109b4ef3c15e8697e5568abf5910f37dba
100644
--- a/athena/main/athena_main.gyp
+++ b/athena/main/athena_main.gyp
@@ -14,10 +14,6 @@
         '../athena.gyp:athena_lib',
         '../athena.gyp:athena_content_lib',
         '../resources/athena_resources.gyp:athena_resources',
-	# debug_widow.cc depends on this. Remove this once debug_window
-	# is removed.
-        '../../ash/ash_resources.gyp:ash_resources',
-        '../../chromeos/chromeos.gyp:power_manager_proto',
         '../../components/components.gyp:component_metrics_proto',
         '../../components/components.gyp:history_core_browser',
         # infobars_test_support is required to declare some symbols used in the
@@ -39,10 +35,6 @@
       'sources': [
         'athena_launcher.cc',
         'athena_launcher.h',
-        'debug/debug_window.cc',
-        'debug/debug_window.h',
-        'debug/network_selector.cc',
-        'debug/network_selector.h',
         'url_search_provider.cc',
         'url_search_provider.h',
         'placeholder.cc',

[pkotwicz, 2014-09-01 20:04:29]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-09-01 20:05:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/483363003/240001

[commit-bot: I haz the power, 2014-09-02 01:05:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-09-02 01:52:17]

Committed patchset #7 (id:240001) as 2c12460759b501e8732cdc43715eb155bee90d34

[commit-bot: I haz the power, 2014-09-10 03:17:37]

Patchset 7 (id:??) landed as
https://crrev.com/73bd924d3996da6e1992b095e3eca90e29c0a10d
Cr-Commit-Position: refs/heads/master@{#292895}