Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1639)

Unified Diff: Source/core/rendering/TextAutosizer.cpp

Issue 482903002: Get rid of loops looking for the first Element ancestor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update one more instance Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/TextAutosizer.cpp
diff --git a/Source/core/rendering/TextAutosizer.cpp b/Source/core/rendering/TextAutosizer.cpp
index 5b3581404bab4d5323dfa210328611c6d40afa7e..2e75f499fe706c3bb35e0646417589149c87a1e6 100644
--- a/Source/core/rendering/TextAutosizer.cpp
+++ b/Source/core/rendering/TextAutosizer.cpp
@@ -121,10 +121,8 @@ static const RenderObject* parentElementRenderer(const RenderObject* renderer)
if (!node)
return 0;
- for (node = node->parentNode(); node; node = node->parentNode()) {
- if (node->isElementNode())
- return node->renderer();
- }
+ if (Element* parent = node->parentElement())
+ return parent->renderer();
esprehn 2014/08/19 01:02:45 This code is wrong, add a FIXME: That it should be
Inactive 2014/08/19 12:51:45 Done.
return 0;
}

Powered by Google App Engine
This is Rietveld 408576698