Source/core/dom/Position.cpp - Issue 482903002: Get rid of loops looking for the first Element ancestor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Position.cpp

Issue 482903002: Get rid of loops looking for the first Element ancestor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update one more instance Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Position.cpp

diff --git a/Source/core/dom/Position.cpp b/Source/core/dom/Position.cpp

index 63fb25c95d51ace7c8bec00fa511bd12260750d0..57412cc93cbeede2e33591cd1e35d805ca413207 100644

--- a/Source/core/dom/Position.cpp

+++ b/Source/core/dom/Position.cpp

@@ -279,9 +279,9 @@ Position::AnchorType Position::anchorTypeForLegacyEditingPosition(Node* anchorNo

Element* Position::element() const

{

Node* n = anchorNode();

- while (n && !n->isElementNode())

- n = n->parentNode();

- return toElement(n);

+ if (!n || n->isElementNode())

+ return toElement(n);

+ return n->parentElement();

esprehn 2014/08/19 01:02:45 n -> node

Inactive 2014/08/19 12:51:45 Done.

}

PassRefPtrWillBeRawPtr<CSSComputedStyleDeclaration> Position::computedStyle() const