Issue 482713002: IDL: Improve "argument needs v8::TryCatch" logic slightly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 482713002: IDL: Improve "argument needs v8::TryCatch" logic slightly (Closed)

Created:
6 years, 4 months ago by Jens Widell

Modified:
6 years, 4 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

IDL: Improve "argument needs v8::TryCatch" logic slightly Enumeration types are effectively strings, and should thus be handled the same, meaning they don't need a v8::TryCatch object. This changes generated code for a few methods that take at least one enumeration type argument, and don't otherwise need a v8::TryCatch, by eliminating the unnecessary v8::TryCatch locals. Also refactor slightly: pass in the IdlOperation object and check whether the return type is Promise inside argument_needs_try_catch(), instead of passing in that fact as an argument. This keeps the logic localized in argument_needs_try_catch(). R=haraken@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180459

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -8 lines)			Patch
M	Source/bindings/scripts/v8_interface.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/scripts/v8_methods.py	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/482713002/1

6 years, 4 months ago (2014-08-18 12:39:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180459

Expand Messages | Collapse Messages