Source/bindings/tests/results/V8TestObject.cpp - Issue 482713002: IDL: Improve "argument needs v8::TryCatch" logic slightly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 482713002: IDL: Improve "argument needs v8::TryCatch" logic slightly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/results/V8TestObject.cpp

diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp

index cca5261d6660a57a4b02eb649d1c00a36d9544d1..171a6d650a574cc4b1f8c6452ac6c1a0746aab6f 100644

--- a/Source/bindings/tests/results/V8TestObject.cpp

+++ b/Source/bindings/tests/results/V8TestObject.cpp

@@ -6652,8 +6652,6 @@ static void voidMethodTestEnumArgMethod(const v8::FunctionCallbackInfo<v8::Value

TestObject* impl = V8TestObject::toNative(info.Holder());

V8StringResource<> testEnumTypeArg;

{

- v8::TryCatch block;

- V8RethrowTryCatchScope rethrow(block);

TOSTRING_VOID_INTERNAL(testEnumTypeArg, info[0]);

String string = testEnumTypeArg;

if (!(string == "" || string == "EnumValue1" || string == "EnumValue2" || string == "EnumValue3")) {

« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | no next file » | no next file with comments »