Fix a trio of autofill popup issues

Fix a couple of autofill popup issues

1. The popup needs to hide when the renderer resizes (akin to hiding on scroll or orientation change).
2. There was a race condition where the renderer could say Show() then Hide(), but the Hide() would fall on deaf ears because the popup was still waiting for webdata.

The linked bug occurred when the render view was auto-resized /after/ an orientation change. After the orientation change we'd get a text field changed event which would trigger the popup to reshow. The fix is to make the renderer resizing close the popup, but (2) and (3) above were necessary for this to actually work.

BUG=401752
Committed: https://crrev.com/48c858891473fdbf4860a1fbdfe44f431d3b3f38
Cr-Commit-Position: refs/heads/master@{#291720}

[Evan Stade, 2014-08-21 00:42:12]

+rouslan for components/autofill/
+jochen for content/

https://codereview.chromium.org/482643004/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/482643004/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.cc:3358: webview()->hidePopups();
note similar behavior here

[please use gerrit instead, 2014-08-21 00:58:57]

Is it possible to add test coverage for this behavior?

[Evan Stade, 2014-08-21 01:02:58]

On 2014/08/21 00:58:57, Rouslan Solomakhin wrote:
> Is it possible to add test coverage for this behavior?

It would be difficult given that I couldn't even figure out a consistent repro
case, besides pinch zooming and rotating the device a bunch of times. Could add
test coverage for stuff like "make sure HidePopup cancels outstanding webdata
requests", but the scope of that kind of test is so narrow I have a hard time
believing it would catch regressions.

[please use gerrit instead, 2014-08-21 01:08:02]

In that case, LGTM, but you better pinch and rotate your device every day to
catch them regressions ;-)

[Evan Stade, 2014-08-21 01:10:21]

jam instead of jochen for content/

[jam, 2014-08-21 21:26:13]

content lgtm

[Evan Stade, 2014-08-21 21:32:24]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-08-21 21:36:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/482643004/1

[commit-bot: I haz the power, 2014-08-22 01:12:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Evan Stade, 2014-08-22 01:29:18]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2014-08-25 16:04:15]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-08-25 16:05:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/482643004/20001

[commit-bot: I haz the power, 2014-08-25 17:26:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-25 18:27:01]

Committed patchset #2 (20001) as 6df92b0ded2258762a269973b67ed535d6b17904

[commit-bot: I haz the power, 2014-09-10 02:35:55]

Patchset 2 (id:??) landed as
https://crrev.com/48c858891473fdbf4860a1fbdfe44f431d3b3f38
Cr-Commit-Position: refs/heads/master@{#291720}