Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 482643004: Fix a trio of autofill popup issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert is_popup_possibly_showing_ chagnes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/renderer/autofill_agent.h" 5 #include "components/autofill/content/renderer/autofill_agent.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 !element->isTextField() || element->isPasswordField()) 239 !element->isTextField() || element->isPasswordField())
240 return; 240 return;
241 241
242 element_ = *element; 242 element_ = *element;
243 } 243 }
244 244
245 void AutofillAgent::OrientationChangeEvent() { 245 void AutofillAgent::OrientationChangeEvent() {
246 HidePopup(); 246 HidePopup();
247 } 247 }
248 248
249 void AutofillAgent::Resized() {
250 HidePopup();
251 }
252
249 void AutofillAgent::DidChangeScrollOffset(WebLocalFrame*) { 253 void AutofillAgent::DidChangeScrollOffset(WebLocalFrame*) {
250 HidePopup(); 254 HidePopup();
251 } 255 }
252 256
253 void AutofillAgent::didRequestAutocomplete( 257 void AutofillAgent::didRequestAutocomplete(
254 const WebFormElement& form) { 258 const WebFormElement& form) {
255 // Disallow the dialog over non-https or broken https, except when the 259 // Disallow the dialog over non-https or broken https, except when the
256 // ignore SSL flag is passed. See http://crbug.com/272512. 260 // ignore SSL flag is passed. See http://crbug.com/272512.
257 // TODO(palmer): this should be moved to the browser process after frames 261 // TODO(palmer): this should be moved to the browser process after frames
258 // get their own processes. 262 // get their own processes.
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
725 // parsed form. 729 // parsed form.
726 if (frame && !frame->parent() && !frame->isLoading()) { 730 if (frame && !frame->parent() && !frame->isLoading()) {
727 ProcessForms(*frame); 731 ProcessForms(*frame);
728 password_autofill_agent_->OnDynamicFormsSeen(frame); 732 password_autofill_agent_->OnDynamicFormsSeen(frame);
729 return; 733 return;
730 } 734 }
731 } 735 }
732 } 736 }
733 737
734 } // namespace autofill 738 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/content/renderer/autofill_agent.h ('k') | components/autofill/core/browser/autocomplete_history_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698