extensions/renderer/resources/send_request.js - Issue 482603002: Unify logic of stack trace generation for extension errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/send_request.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add $Error and $String.indexOf to safe builtins Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/resources/schema_utils.js ('K') | « extensions/renderer/resources/schema_utils.js ('k') | extensions/renderer/resources/set_icon.js » ('j') | extensions/renderer/resources/set_icon.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/send_request.js

diff --git a/extensions/renderer/resources/send_request.js b/extensions/renderer/resources/send_request.js

index 7cdc7d16936a19a267258e217ccc4fd0a853433c..1da604f89c85c02a573924cfeb7b92099b2d169a 100644

--- a/extensions/renderer/resources/send_request.js

+++ b/extensions/renderer/resources/send_request.js

@@ -67,7 +67,7 @@ function handleResponse(requestId, name, success, responseList, error) {

// has not provided a callback.

if (logging.DCHECK_IS_ON() && !error) {

if (!request.callbackSchema.parameters)

- throw new Error(name + ": no callback schema defined");

+ throw new $Error.self(name + ": no callback schema defined");

validate(responseList, request.callbackSchema.parameters);

}

safeCallbackApply(name, request, request.callback, responseList);