Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: extensions/renderer/resources/schema_utils.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add $Error and $String.indexOf to safe builtins Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/schema_utils.js
diff --git a/extensions/renderer/resources/schema_utils.js b/extensions/renderer/resources/schema_utils.js
index c0cb77712f28e7ebb32e5c9ab2b39ace49fd73df..a2d38664f1020ff66673d7398ba3ad42b866d83e 100644
--- a/extensions/renderer/resources/schema_utils.js
+++ b/extensions/renderer/resources/schema_utils.js
@@ -12,7 +12,7 @@ var schemaValidator = new JSONSchemaValidator();
// Validate arguments.
function validate(args, parameterSchemas) {
if (args.length > parameterSchemas.length)
- throw new Error("Too many arguments.");
+ throw new $Error.self("Too many arguments.");
for (var i = 0; i < parameterSchemas.length; i++) {
if (i in args && args[i] !== null && args[i] !== undefined) {
schemaValidator.resetErrors();
@@ -31,9 +31,9 @@ function validate(args, parameterSchemas) {
}
message = message.substring(0, message.length - 2);
message += ".";
- throw new Error(message);
+ throw new $Error.self(message);
} else if (!parameterSchemas[i].optional) {
- throw new Error("Parameter " + (i + 1) + " (" +
+ throw new $Error.self("Parameter " + (i + 1) + " (" +
parameterSchemas[i].name + ") is required.");
}
}
@@ -110,7 +110,7 @@ function normalizeArgumentsAndValidate(args, funDef) {
var definedSignature = funDef.definition.parameters;
var resolvedSignature = resolveSignature(args, definedSignature);
if (!resolvedSignature)
- throw new Error("Invocation of form " +
+ throw new $Error.self("Invocation of form " +
not at google - send to devlin 2014/08/19 16:45:56 new Error() for this whole file.
getArgumentSignatureString(funDef.name, args) +
" doesn't match definition " +
getParameterSignatureString(funDef.name, definedSignature));

Powered by Google App Engine
This is Rietveld 408576698