extensions/renderer/resources/permissions_custom_bindings.js - Issue 482603002: Unify logic of stack trace generation for extension errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/permissions_custom_bindings.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add $Error and $String.indexOf to safe builtins Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/resources/messaging.js ('K') | « extensions/renderer/resources/messaging.js ('k') | extensions/renderer/resources/platform_app.js » ('j') | extensions/renderer/resources/platform_app.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/permissions_custom_bindings.js

diff --git a/extensions/renderer/resources/permissions_custom_bindings.js b/extensions/renderer/resources/permissions_custom_bindings.js

index 60edfaa40efc595d2b8281de1f0a19dd2a850149..8b64623dbf85ca392bd47042a3a1802fb7495592 100644

--- a/extensions/renderer/resources/permissions_custom_bindings.js

+++ b/extensions/renderer/resources/permissions_custom_bindings.js

@@ -42,7 +42,7 @@ binding.registerCustomHook(function(api) {

var a = args[i];

var keys = $Object.keys(a);

if (keys.length != 1) {

- throw new Error("Too many keys in object-style permission.");

+ throw new $Error.self("Too many keys in object-style permission.");

not at google - send to devlin 2014/08/19 16:45:56 new Error() ... I think? This stuff is confusing.

}

arguments[0].permissions[i] = keys[0] + '|' +

JSON.stringify(a[keys[0]]);