extensions/renderer/resources/messaging.js - Issue 482603002: Unify logic of stack trace generation for extension errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/messaging.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add $Error and $String.indexOf to safe builtins Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/resources/extension_custom_bindings.js ('K') | « extensions/renderer/resources/last_error.js ('k') | extensions/renderer/resources/permissions_custom_bindings.js » ('j') | extensions/renderer/resources/permissions_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/messaging.js

diff --git a/extensions/renderer/resources/messaging.js b/extensions/renderer/resources/messaging.js

index 5a83654c501357ad0b0a8c6578aa464076eb3fe8..1a9b69f7a6cc8b6313a2b43372196b93e2c0a753 100644

--- a/extensions/renderer/resources/messaging.js

+++ b/extensions/renderer/resources/messaging.js

@@ -102,7 +102,7 @@

// people add arbitrary port IDs to the port list.

function createPort(portId, opt_name) {

if (ports[portId])

- throw new Error("Port '" + portId + "' already exists.");

+ throw new $Error.self("Port '" + portId + "' already exists.");

var port = new Port(portId, opt_name);

ports[portId] = port;

portReleasers[portId] = $Function.bind(messagingNatives.PortRelease,

@@ -357,7 +357,7 @@

var alignedArgs = messagingUtils.alignSendMessageArguments(args,

hasOptionsArgument);

if (!alignedArgs)

- throw new Error('Invalid arguments to ' + functionName + '.');

+ throw new $Error.self('Invalid arguments to ' + functionName + '.');

not at google - send to devlin 2014/08/19 16:45:56 new Error()

return alignedArgs;

}