Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: extensions/renderer/resources/last_error.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add $Error and $String.indexOf to safe builtins Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/last_error.js
diff --git a/extensions/renderer/resources/last_error.js b/extensions/renderer/resources/last_error.js
index 8d53371827acd01eeaa12840bd71497b5bb90120..f0f091de71b8441888496ac9668094ce9e49b5d6 100644
--- a/extensions/renderer/resources/last_error.js
+++ b/extensions/renderer/resources/last_error.js
@@ -24,7 +24,7 @@ function set(name, message, stack, targetChrome) {
errorMessage += '\n' + stack;
if (!targetChrome)
- throw new Error('No chrome object to set error: ' + errorMessage);
+ throw new $Error.self('No chrome object to set error: ' + errorMessage);
clear(targetChrome); // in case somebody has set a sneaky getter/setter
var errorObject = { message: message };
@@ -65,7 +65,7 @@ function hasAccessed(targetChrome) {
*/
function hasError(targetChrome) {
if (!targetChrome)
- throw new Error('No target chrome to check');
+ throw new $Error.self('No target chrome to check');
assertRuntimeIsAvailable();
if ('lastError' in targetChrome.runtime)
@@ -79,7 +79,7 @@ function hasError(targetChrome) {
*/
function clear(targetChrome) {
if (!targetChrome)
- throw new Error('No target chrome to clear error');
+ throw new $Error.self('No target chrome to clear error');
if (GetAvailability('extension.lastError').is_available)
delete targetChrome.extension.lastError;
@@ -94,11 +94,11 @@ function assertRuntimeIsAvailable() {
// some reason? Add debugging for http://crbug.com/258526.
var runtimeAvailability = GetAvailability('runtime.lastError');
if (!runtimeAvailability.is_available) {
- throw new Error('runtime.lastError is not available: ' +
+ throw new $Error.self('runtime.lastError is not available: ' +
runtimeAvailability.message);
}
if (!chrome.runtime)
- throw new Error('runtime namespace is null or undefined');
+ throw new $Error.self('runtime namespace is null or undefined');
}
/**

Powered by Google App Engine
This is Rietveld 408576698