Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: extensions/renderer/resources/extension_custom_bindings.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add $Error and $String.indexOf to safe builtins Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/extension_custom_bindings.js
diff --git a/extensions/renderer/resources/extension_custom_bindings.js b/extensions/renderer/resources/extension_custom_bindings.js
index d114f527f56e92418cb4c8b54a4623b7d3a7b145..355274c21255accc3d3583e7a0c56b888e8e34af 100644
--- a/extensions/renderer/resources/extension_custom_bindings.js
+++ b/extensions/renderer/resources/extension_custom_bindings.js
@@ -92,7 +92,7 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {
apiFunctions.setHandleRequest('sendRequest',
function(targetId, request, responseCallback) {
if (sendRequestIsDisabled)
- throw new Error(sendRequestIsDisabled);
+ throw new $Error.self(sendRequestIsDisabled);
var port = chrome.runtime.connect(targetId || extensionId,
{name: messaging.kRequestChannel});
messaging.sendMessageImpl(port, request, responseCallback);
@@ -100,11 +100,11 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {
if (sendRequestIsDisabled) {
extension.onRequest.addListener = function() {
- throw new Error(sendRequestIsDisabled);
+ throw new $Error.self(sendRequestIsDisabled);
};
if (contextType == 'BLESSED_EXTENSION') {
extension.onRequestExternal.addListener = function() {
- throw new Error(sendRequestIsDisabled);
+ throw new $Error.self(sendRequestIsDisabled);
not at google - send to devlin 2014/08/19 16:45:55 All of these: new Error()
};
}
}

Powered by Google App Engine
This is Rietveld 408576698