chrome/renderer/resources/extensions/file_system_custom_bindings.js - Issue 482603002: Unify logic of stack trace generation for extension errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/file_system_custom_bindings.js

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update expected stack trace length Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/error_console/error_console_browsertest.cc ('k') | chrome/renderer/resources/extensions/page_capture_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/file_system_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/file_system_custom_bindings.js b/chrome/renderer/resources/extensions/file_system_custom_bindings.js

index b74d2cae880e4a1e21ae58741d050c681dd381fd..30a8aca48e2726a733d39f4ab179a3771ade8e95 100644

--- a/chrome/renderer/resources/extensions/file_system_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/file_system_custom_bindings.js

@@ -51,7 +51,7 @@ binding.registerCustomHook(function(bindingsAPI) {

if (savedEntry) {

sendRequest.safeCallbackApply(

'fileSystem.isRestorable',

- {'stack': sendRequest.getExtensionStackTrace()},

+ {},

callback,

[true]);

} else {

@@ -68,7 +68,7 @@ binding.registerCustomHook(function(bindingsAPI) {

// send a request to the browser to move it to the back of the LRU.

sendRequest.safeCallbackApply(

'fileSystem.restoreEntry',

- {'stack': sendRequest.getExtensionStackTrace()},

+ {},

callback,

[savedEntry]);

return [id, false, null];