Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4504)

Unified Diff: chrome/browser/extensions/error_console/error_console_browsertest.cc

Issue 482603002: Unify logic of stack trace generation for extension errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update expected stack trace length Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/file_system_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/error_console/error_console_browsertest.cc
diff --git a/chrome/browser/extensions/error_console/error_console_browsertest.cc b/chrome/browser/extensions/error_console/error_console_browsertest.cc
index d4619f50782a0c4e1c752ee6f6f1c29354adec49..a4a479b9c1994cceaff418a3cb70ad8c8640d411 100644
--- a/chrome/browser/extensions/error_console/error_console_browsertest.cc
+++ b/chrome/browser/extensions/error_console/error_console_browsertest.cc
@@ -448,22 +448,18 @@ IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, BrowserActionRuntimeError) {
extension->id(),
script_url,
false, // not incognito
- "Error in event handler for browserAction.onClicked: baz is not defined\n"
- "Stack trace: ReferenceError: baz is not defined",
+ "Error in event handler for browserAction.onClicked: ReferenceError: "
+ "baz is not defined",
logging::LOG_ERROR,
extension->url().Resolve(kBackgroundPageName),
- 6u);
+ 1u);
const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
+ // Note: This test used to have a stack trace of length 6 that contains stack
+ // frames in the extension code, but since crbug.com/404406 was fixed only
+ // stack frames within user-defined extension code are printed.
CheckStackFrame(stack_trace[0], script_url, kAnonymousFunction);
- CheckStackFrame(stack_trace[1], event_bindings_str,
- "EventImpl.dispatchToListener");
- CheckStackFrame(stack_trace[2], "extensions::utils",
- event_dispatch_to_listener_str);
- CheckStackFrame(stack_trace[3], event_bindings_str, "EventImpl.dispatch_");
- CheckStackFrame(stack_trace[4], event_bindings_str, "dispatchArgs");
- CheckStackFrame(stack_trace[5], event_bindings_str, "dispatchEvent");
}
// Test that we can catch an error for calling an API with improper arguments.
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/file_system_custom_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698