Chromium Code Reviews
Help | Chromium Project | Sign in
(280)

Issue 4825001: auth-int qop is ignored for Digest authentication (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by cbentzel
Modified:
3 years, 11 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Improve unit test coverage of HttpAuthHandlerDigest parsing. Also, if the only qop is auth-int, use a different handler since this is not currently handled. BUG=45194 TEST=net_unittests --gtest_filter="*HttpAuthHandlerDigest*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66137

Patch Set 1 #

Patch Set 2 : Remove extra LOG(ERROR) #

Total comments: 5

Patch Set 3 : '' #

Patch Set 4 : new description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -31 lines) Patch
M net/http/http_auth_handler_digest.h View 3 chunks +7 lines, -8 lines 0 comments Download
M net/http/http_auth_handler_digest.cc View 1 2 4 chunks +14 lines, -10 lines 0 comments Download
M net/http/http_auth_handler_digest_unittest.cc View 1 2 7 chunks +174 lines, -13 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
cbentzel
The key thing I want to know is whether the qop=auth-int is handled correctly in ...
4 years, 5 months ago (2010-11-11 21:59:20 UTC) #1
eroman
LGTM thanks. Regarding the CL description, I think it would be better described as something ...
4 years, 5 months ago (2010-11-11 23:02:57 UTC) #2
cbentzel
On Thu, Nov 11, 2010 at 6:02 PM, <eroman@chromium.org> wrote: > > auth-int is more ...
4 years, 5 months ago (2010-11-11 23:10:56 UTC) #3
cbentzel
4 years, 5 months ago (2010-11-12 16:01:52 UTC) #4
After re-reading http://crbug.com/45194 (and reading RFC2617 again), it seems
like we can just ignore the auth-int qop and fall back to a lower qop, while
still doing digest.

This also cleans up the code a bit - rather than using a bitmask QOP enum, I
just have exclusive values.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e0e3771