Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: net/http/http_auth_handler_digest.h

Issue 4825001: auth-int qop is ignored for Digest authentication (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: new description Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_digest.h
===================================================================
--- net/http/http_auth_handler_digest.h (revision 63735)
+++ net/http/http_auth_handler_digest.h (working copy)
@@ -63,12 +63,11 @@
ALGORITHM_MD5_SESS,
};
- // Possible values for "qop" -- may be or-ed together if there were
- // multiple comma separated values.
+ // Possible values for QualityOfProtection.
+ // auth-int is not supported, see http://crbug.com/62890 for justification.
enum QualityOfProtection {
- QOP_UNSPECIFIED = 0,
- QOP_AUTH = 1 << 0,
- QOP_AUTH_INT = 1 << 1,
+ QOP_UNSPECIFIED,
+ QOP_AUTH,
};
explicit HttpAuthHandlerDigest(int nonce_count);
@@ -86,8 +85,8 @@
static std::string GenerateNonce();
// Convert enum value back to string.
- static std::string QopToString(int qop);
- static std::string AlgorithmToString(int algorithm);
+ static std::string QopToString(QualityOfProtection qop);
+ static std::string AlgorithmToString(DigestAlgorithm algorithm);
// Extract the method and path of the request, as needed by
// the 'A2' production. (path may be a hostname for proxy).
@@ -122,7 +121,7 @@
std::string opaque_;
bool stale_;
DigestAlgorithm algorithm_;
- int qop_; // Bitfield of QualityOfProtection
+ QualityOfProtection qop_;
int nonce_count_;
« no previous file with comments | « no previous file | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698