Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 482333003: Reland r290125: Close all active PeerConnections upon OS suspend (Closed)

Created:
6 years, 4 months ago by vrk (LEFT CHROMIUM)
Modified:
6 years, 4 months ago
Reviewers:
jiayl, juberti2, nasko
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland r290125: Close all active PeerConnections upon OS suspend This replaces the CHECK with an if statement because the RenderProcessHost is cleaned up before deletion, which means it can be unregistered from the list of available RenderProcessHosts before being destructed (hence CHECK firing). BUG=403618, 404715 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290757

Patch Set 1 : original cl #

Patch Set 2 : replaces CHECK with if #

Patch Set 3 : remove semi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M content/browser/renderer_host/media/peer_connection_tracker_host.h View 3 chunks +9 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/peer_connection_tracker_host.cc View 1 3 chunks +17 lines, -1 line 0 comments Download
M content/common/media/peer_connection_tracker_messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/peer_connection_tracker.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/peer_connection_tracker.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
vrk (LEFT CHROMIUM)
Had to revert r290125 because the CHECK was firing. This is the CL to reland ...
6 years, 4 months ago (2014-08-19 01:01:10 UTC) #1
nasko
It is unfortunate that we unregister the process and delete it later, leaving the filters ...
6 years, 4 months ago (2014-08-19 17:17:41 UTC) #2
jiayl
lgtm
6 years, 4 months ago (2014-08-19 17:41:45 UTC) #3
jiayl
lgtm
6 years, 4 months ago (2014-08-19 17:41:46 UTC) #4
vrk (LEFT CHROMIUM)
The CQ bit was checked by vrk@chromium.org
6 years, 4 months ago (2014-08-19 17:45:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/482333003/40001
6 years, 4 months ago (2014-08-19 17:46:55 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 19:06:28 UTC) #7
vrk (LEFT CHROMIUM)
The CQ bit was unchecked by vrk@chromium.org
6 years, 4 months ago (2014-08-19 19:35:01 UTC) #8
vrk (LEFT CHROMIUM)
The CQ bit was checked by vrk@chromium.org
6 years, 4 months ago (2014-08-20 01:19:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/482333003/60001
6 years, 4 months ago (2014-08-20 01:20:31 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 03:08:52 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 04:10:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (60001) as 290757

Powered by Google App Engine
This is Rietveld 408576698