chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java - Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the nit. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java ('K') | « chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java ('k') | chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java » ('j') | content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

index a88405063d3727f264b9f1226c9c57c1cb2bc31c..db480d52230f2e7b09b007e0da343e1ee49c5886 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

@@ -77,7 +77,7 @@ public class ChromeShellToolbar extends LinearLayout {

if (mTab != null) mTab.removeObserver(mTabObserver);

mTab = tab;

mTab.addObserver(mTabObserver);

- mUrlTextView.setText(mTab.getContentViewCore().getUrl());

+ mUrlTextView.setText(mTab.getContentViewCore().getWebContents().getUrl());

Yaron 2014/08/18 23:16:24 Tab exposes getWebContents. Please use directly (t

AKVT 2014/09/11 17:19:43 Done.

}

private void onUpdateUrl(String url) {

@@ -135,7 +135,7 @@ public class ChromeShellToolbar extends LinearLayout {

public void onFocusChange(View v, boolean hasFocus) {

setKeyboardVisibilityForUrl(hasFocus);

if (!hasFocus) {

- mUrlTextView.setText(mTab.getContentViewCore().getUrl());

+ mUrlTextView.setText(mTab.getContentViewCore().getWebContents().getUrl());

mSuggestionPopup.dismissPopup();

}