chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java - Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the nit. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java ('k') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java » ('j') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

index ba7e758e83793717c0a5114caccf75a3a007a485..9b27280db1a31d3c10985a65478da98b7c201cbe 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

@@ -63,7 +63,7 @@ public class ChromeShellTab extends Tab {

if (TextUtils.isEmpty(url)) return;

ContentViewCore contentViewCore = getContentViewCore();

Yaron 2014/08/18 23:16:24 We should remove the CVC dependency entirely when

AKVT 2014/09/11 17:19:43 Done. Thanks

- if (TextUtils.equals(url, contentViewCore.getUrl())) {

+ if (TextUtils.equals(url, contentViewCore.getWebContents().getUrl())) {

contentViewCore.reload(true);

} else {

if (postData == null) {