chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java - Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the nit. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerFeedbackReporter.java » ('j') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

index c08565526231580f4be23ebd5e0fe49c14028ffe..9f371b8371355a456ca878110a26e4b9b4c6a813 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

@@ -226,7 +226,7 @@ public class AppBannerManager implements AppBannerView.Observer, AppDetailsDeleg

private boolean isBannerForCurrentPage(String bannerUrl) {

return mContentViewCore != null &&

- TextUtils.equals(mContentViewCore.getUrl(), bannerUrl);

+ TextUtils.equals(mContentViewCore.getWebContents().getUrl(), bannerUrl);

}

private static native boolean nativeIsEnabled();