android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java - Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the nit. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('j') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java

diff --git a/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java b/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java

index 8c9cf82ecb994b8e312d2497055eb78c01abc4b9..d46f0a19cda1af61aca33d0dcd35de503412db8a 100644

--- a/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java

+++ b/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java

@@ -180,7 +180,8 @@ public class AwShellActivity extends Activity {

mNextButton.setVisibility(hasFocus ? View.GONE : View.VISIBLE);

mPrevButton.setVisibility(hasFocus ? View.GONE : View.VISIBLE);

if (!hasFocus) {

- mUrlTextView.setText(mAwTestContainerView.getContentViewCore().getUrl());

+ mUrlTextView.setText(mAwTestContainerView.getContentViewCore().

+ getWebContents().getUrl());

}

});