android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java - Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the nit. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/SaveRestoreStateTest.java » ('j') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

index b4307f10e717285f888391d7d50bdfa0877bebba..9f3135c3ff63e2de1163a826b00188d146134193 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

@@ -288,7 +288,7 @@ public class NavigationHistoryTest extends AwTestBase {

pollOnUiThread(new Callable<Boolean>() {

@Override

public Boolean call() {

- String title = mAwContents.getContentViewCore().getTitle();

+ String title = mAwContents.getTitle();

return LOGIN_RESPONSE_PAGE_TITLE.equals(title);

}

});

@@ -299,7 +299,7 @@ public class NavigationHistoryTest extends AwTestBase {

pollOnUiThread(new Callable<Boolean>() {

@Override

public Boolean call() {

- String title = mAwContents.getContentViewCore().getTitle();

+ String title = mAwContents.getTitle();

return PAGE_1_TITLE.equals(title);

}

});

@@ -310,7 +310,7 @@ public class NavigationHistoryTest extends AwTestBase {

pollOnUiThread(new Callable<Boolean>() {

@Override

public Boolean call() {

- String title = mAwContents.getContentViewCore().getTitle();

+ String title = mAwContents.getTitle();

return LOGIN_RESPONSE_PAGE_TITLE.equals(title);

}

});