Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2561)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nits. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
index f123585d215f947a6a65e0f46d889d5e373eb81a..db6dc877fee1aa050eff46ad6696e781ee626e99 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
@@ -60,7 +60,7 @@ public class NavigationHistoryTest extends AwTestBase {
return ThreadUtils.runOnUiThreadBlocking(new Callable<NavigationHistory>() {
@Override
public NavigationHistory call() {
- return awContents.getContentViewCore().getNavigationHistory();
+ return awContents.getNavigationController().getNavigationHistory();
}
});
}
@@ -171,8 +171,8 @@ public class NavigationHistoryTest extends AwTestBase {
loadUrlSync(mAwContents, onPageFinishedHelper, page1Url);
loadUrlSync(mAwContents, onPageFinishedHelper, page2Url);
- HistoryUtils.goBackSync(getInstrumentation(), mAwContents.getContentViewCore(),
- onPageFinishedHelper);
+ HistoryUtils.goBackSync(getInstrumentation(), mAwContents.getContentViewCore()
boliu 2014/09/13 00:38:54 ditto
AKVT 2014/09/13 11:30:50 Done.
+ .getWebContents(), onPageFinishedHelper);
list = getNavigationHistory(mAwContents);
// Make sure the first entry is still okay
@@ -288,7 +288,7 @@ public class NavigationHistoryTest extends AwTestBase {
pollOnUiThread(new Callable<Boolean>() {
@Override
public Boolean call() {
- String title = mAwContents.getContentViewCore().getTitle();
+ String title = mAwContents.getTitle();
return LOGIN_RESPONSE_PAGE_TITLE.equals(title);
}
});
@@ -299,18 +299,18 @@ public class NavigationHistoryTest extends AwTestBase {
pollOnUiThread(new Callable<Boolean>() {
@Override
public Boolean call() {
- String title = mAwContents.getContentViewCore().getTitle();
+ String title = mAwContents.getTitle();
return PAGE_1_TITLE.equals(title);
}
});
// Verify that we can still go back to the login response page despite that
// it is non-cacheable.
- HistoryUtils.goBackSync(getInstrumentation(), mAwContents.getContentViewCore(),
- onPageFinishedHelper);
+ HistoryUtils.goBackSync(getInstrumentation(), mAwContents.getContentViewCore()
boliu 2014/09/13 00:38:53 ditto
AKVT 2014/09/13 11:30:50 Done.
+ .getWebContents(), onPageFinishedHelper);
pollOnUiThread(new Callable<Boolean>() {
@Override
public Boolean call() {
- String title = mAwContents.getContentViewCore().getTitle();
+ String title = mAwContents.getTitle();
return LOGIN_RESPONSE_PAGE_TITLE.equals(title);
}
});

Powered by Google App Engine
This is Rietveld 408576698