android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java - Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed nits. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java ('K') | « android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java » ('j') | android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

index fa9707dd7e5d653fbf8a4e725084a1c3c33eaf24..916cce799dc4a4f8c24fd97bf9e27b550f44ba77 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

@@ -323,7 +323,7 @@ public class LoadUrlTest extends AwTestBase {

validateNoRequestHeaders(extraHeaders, webServer.getLastRequest(nextPath));

HistoryUtils.goBackSync(getInstrumentation(),

- awContents.getContentViewCore(),

+ awContents.getContentViewCore().getWebContents(),

boliu 2014/09/13 00:38:53 ditto

AKVT 2014/09/13 11:30:50 Done.

contentsClient.getOnPageFinishedHelper());

assertEquals(2, webServer.getRequestCount(path));

validateRequestHeaders(extraHeaders, webServer.getLastRequest(path));