chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java - Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed few nits. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java ('K') | « chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java

diff --git a/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java b/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java

index 4f0fa57f2f296391c2f5a1f03c4e4c25e604a8a6..37a8199290a0061440a665fcfb7adfb851dd76cd 100644

--- a/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java

+++ b/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java

@@ -64,9 +64,10 @@ public class ChromeShellUrlTest extends ChromeShellTestBase {

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override

public void run() {

- isShowingInterstitialPage.set(contentViewCore.get().isShowingInterstitialPage());

- url.set(contentViewCore.get().getUrl());

- title.set(contentViewCore.get().getTitle());

+ isShowingInterstitialPage.set(contentViewCore.get().getWebContents().

Ted C 2014/09/12 00:40:36 same :-) I'll just say look at all following file

AKVT 2014/09/12 14:37:11 Done.

+ isShowingInterstitialPage());

+ url.set(contentViewCore.get().getWebContents().getUrl());

+ title.set(contentViewCore.get().getWebContents().getTitle());

}

});

assertFalse("Showed interstitial page instead of welcome page",