chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java - Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java

Issue 481803004: Removing ContentViewCore dependencies from few functions which acts as direct wrapper to WebContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed few nits. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java ('K') | « chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java ('k') | chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java » ('j') | chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java

diff --git a/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java b/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java

index 01d160c8faa4f149dc8cdba0ae626d1ba06a5500..0724d5880d6f8fc58a8ea161f633fd76a502f6f7 100644

--- a/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java

+++ b/chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java

@@ -95,7 +95,8 @@ public class ChromeShellTestBase extends ActivityInstrumentationTestCase2<Chrome

ChromeShellTab tab = activity.getActiveTab();

if (tab != null) {

isLoaded.set(!tab.isLoading()

- && !TextUtils.isEmpty(tab.getContentViewCore().getUrl()));

+ && !TextUtils.isEmpty(tab.getContentViewCore().

+ getWebContents().getUrl()));

Ted C 2014/09/12 00:40:36 here too

AKVT 2014/09/12 14:37:11 Done.

} else {

isLoaded.set(false);

}