Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2103)

Unified Diff: content/browser/android/popup_touch_handle_drawable.cc

Issue 481683003: Support for Adaptive Handle Orientation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: some more cleaning up Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/popup_touch_handle_drawable.cc
diff --git a/content/browser/android/popup_touch_handle_drawable.cc b/content/browser/android/popup_touch_handle_drawable.cc
index ac2f57bffc2d56241483fb2da171861d8a399239..fa39ec3ba6990983f02f42c50a981dfdf354c357 100644
--- a/content/browser/android/popup_touch_handle_drawable.cc
+++ b/content/browser/android/popup_touch_handle_drawable.cc
@@ -43,6 +43,15 @@ void PopupTouchHandleDrawable::SetOrientation(
Java_PopupTouchHandleDrawable_setCenterOrientation(env, obj);
break;
+ // Inverted/flipped handles are not currently supported for
+ // synchronous (WebView) compositor case.
jdduke (slow) 2014/08/20 15:15:01 WebView is probably the *most* useful case for inv
AviD 2014/08/21 16:15:20 If the handles were to be drawn on top of Selected
+ case TOUCH_HANDLE_LEFT_INVERTED:
+ case TOUCH_HANDLE_RIGHT_INVERTED:
+ case TOUCH_HANDLE_LEFT_FLIPPED:
+ case TOUCH_HANDLE_RIGHT_FLIPPED:
+ case TOUCH_HANDLE_LEFT_FLIPPED_INVERTED:
+ case TOUCH_HANDLE_RIGHT_FLIPPED_INVERTED:
+ case TOUCH_HANDLE_CENTER_INVERTED:
case TOUCH_HANDLE_ORIENTATION_UNDEFINED:
NOTREACHED() << "Invalid touch handle orientation.";
};

Powered by Google App Engine
This is Rietveld 408576698