Support for Adaptive Handle Orientation

content/browser/android/popup_touch_handle_drawable.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/popup_touch_handle_drawable.h"
 
 #include "jni/PopupTouchHandleDrawable_jni.h"
 
 namespace content {
 
@@ skipping 25 matching lines @@
       break;
 
     case TOUCH_HANDLE_RIGHT:
       Java_PopupTouchHandleDrawable_setRightOrientation(env, obj);
       break;
 
     case TOUCH_HANDLE_CENTER:
       Java_PopupTouchHandleDrawable_setCenterOrientation(env, obj);
       break;
 
+    // Inverted/flipped handles are not currently supported for
+    // synchronous (WebView) compositor case.

[jdduke (slow), 2014/08/20 15:15:01]

WebView is probably the *most* useful case for inverting handles, so this is a
little confusing.

[AviD, 2014/08/21 16:15:20]

If the handles were to be drawn on top of Selected text(as the bug description),
then it would be a round about approach to get the top of selection (start_rect
and end_rect) on java(PopuptouchHandleDrawable) side.
But if we anchor the handles to the bottom of selection(as per your suggestion),
then it can be implemented without having to consider the selection height.
I'll work on bringing this on WebView also.

+    case TOUCH_HANDLE_LEFT_INVERTED:
+    case TOUCH_HANDLE_RIGHT_INVERTED:
+    case TOUCH_HANDLE_LEFT_FLIPPED:
+    case TOUCH_HANDLE_RIGHT_FLIPPED:
+    case TOUCH_HANDLE_LEFT_FLIPPED_INVERTED:
+    case TOUCH_HANDLE_RIGHT_FLIPPED_INVERTED:
+    case TOUCH_HANDLE_CENTER_INVERTED:
     case TOUCH_HANDLE_ORIENTATION_UNDEFINED:
       NOTREACHED() << "Invalid touch handle orientation.";
   };
 }
 
 void PopupTouchHandleDrawable::SetAlpha(float alpha) {
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_PopupTouchHandleDrawable_setOpacity(env, drawable_.obj(), alpha);
 }
 
@@ skipping 19 matching lines @@
                                                       rect_pix.width(),
                                                       rect_pix.height());
 }
 
 // static
 bool PopupTouchHandleDrawable::RegisterPopupTouchHandleDrawable(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content