Issue 481653002: Fix harfbuzz compile on Windows LKGRs after r290100

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 481653002: Fix harfbuzz compile on Windows LKGRs after r290100 (Closed)

Created:
6 years, 4 months ago by jschuh

Modified:
6 years, 4 months ago

Reviewers:
Dominik Röttsches, behdad_google, Nico, eae, behdad

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -3 lines)			Patch
M	third_party/harfbuzz-ng/README.chromium	View	1 chunk	+3 lines, -2 lines	0 comments	Download
A	third_party/harfbuzz-ng/google.patch	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	third_party/harfbuzz-ng/src/hb-private.hh	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/481653002/1

6 years, 4 months ago (2014-08-16 14:12:09 UTC) #2

jschuh

On 2014/08/16 14:31:20, Nico (very away) wrote: > probably want to merge this in harfbuzz ...

6 years, 4 months ago (2014-08-16 14:34:05 UTC) #5

Message was sent while issue was closed.

lgtm

lgtm

This is upstream already.