Roll HarfBuzz to 0.9.35

Roll HarfBuzz to 0.9.35

0.9.35 contains a couple of fixes for the CoreText shaper
backend, which are required to work on removing the CoreText
codepaths in Blink.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290100

[Dominik Röttsches, 2014-08-15 11:58:43]

Depends on https://codereview.chromium.org/476113002/ for allowing HarfBuzz'
header include order.

[bashi, 2014-08-15 12:51:09]

LGTM.

It would be helpful if you could submit tryjobs to ensure that we won't break
builds.

[Dominik Röttsches, 2014-08-15 12:59:32]

Thanks for the review.

> It would be helpful if you could submit tryjobs to ensure that we won't break
> builds.

Sure - I was waiting for the presubmit script fix to land and thought I was
blocked by it, but of course, I can run the tryjobs independently.

[eae, 2014-08-15 15:38:21]

LGTM

[behdad_google, 2014-08-15 18:12:54]

lgtm

[Dominik Röttsches, 2014-08-15 20:06:58]

The CQ bit was checked by dominik.rottsches@intel.com

[commit-bot: I haz the power, 2014-08-15 20:12:09]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/475363002/...

[commit-bot: I haz the power, 2014-08-16 00:36:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-16 06:00:06]

Committed patchset #2 (20001) as 290100

[jschuh, 2014-08-16 13:44:11]

This broke the compile on Win64 LKGR and official:

FAILED: ninja -t msvc -e environment.x64 --
"C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo
/showIncludes /FC @obj\third_party\harfbuzz-ng\src\harfbuzz-ng.hb-blob.obj.rsp
/c ..\..\third_party\harfbuzz-ng\src\hb-blob.cc
/Foobj\third_party\harfbuzz-ng\src\harfbuzz-ng.hb-blob.obj
/Fdobj\third_party\harfbuzz-ng\harfbuzz-ng.cc.pdb 
c:\b\build\slave\win_x64\build\src\third_party\harfbuzz-ng\src\hb-private.hh(134)
: error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64\build\src\third_party\harfbuzz-ng\src\hb-private.hh(134)
: warning C4005: 'STRICT' : macro redefinition
       
c:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\include\shared\minwindef.h(23)
: see previous definition of 'STRICT'

Not sure why it isn't broken on the waterfall. More context here:
http://build.chromium.org/p/chromium.lkgr/builders/Win%20x64/builds/2328

[jschuh, 2014-08-16 13:51:18]

Apparently we're not building harfbuzz for Windows anywhere on the waterfall,
but there are still targets that cause it to get built on Windows (hence the
broken LKGRs). And to clarify, this isn't a Win64 thing. This CL broke both all
Windows LKGRs. Should we just not be building this anywhere on Windows?

[jschuh, 2014-08-16 14:14:43]

I landed a trivial fix for the Windows build breakage:
https://src.chromium.org/viewvc/chrome?view=rev&revision=290144

Do any of you know how to upstream that so we can avoid carrying a local patch?

[bashi, 2014-08-16 15:36:33]

On 2014/08/16 14:14:43, Justin Schuh wrote:
> I landed a trivial fix for the Windows build breakage:
> https://src.chromium.org/viewvc/chrome?view=rev&revision=290144
> 
> Do any of you know how to upstream that so we can avoid carrying a local
patch?

It seems that behdad@ already fixed it.
https://github.com/bashi/harfbuzz/commit/270971a0fccdf4964fd3e8ab8e5cf53037a3...

[Dominik Röttsches, 2014-08-18 07:59:31]

Sorry about that - my fix attempt apparently only fixed it half the way - and
the bots went green, so I thought it's fine. How can we clear up the mismatch
between the LKGR and the trybots?