Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 481593002: Remove child/route parameters from ShouldBeginRequest and RequestBeginning. (Closed)

Created:
6 years, 4 months ago by davidben
Modified:
6 years, 4 months ago
Reviewers:
jam, benm (inactive)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Remove child/route parameters from ShouldBeginRequest and RequestBeginning. They were mostly unused. Move remaining uses to calls to GetChildID, though we'll possibly need to adjust them later. BUG=376003 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291098

Patch Set 1 #

Patch Set 2 : WebView changes #

Patch Set 3 : Missed some others. #

Patch Set 4 : android build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -57 lines) Patch
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 3 5 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/signin/signin_header_helper.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/signin/signin_header_helper.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/cross_site_transfer_browsertest.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/transition_browsertest.cc View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
davidben
6 years, 4 months ago (2014-08-15 23:02:17 UTC) #1
jam
lgtm
6 years, 4 months ago (2014-08-18 17:56:50 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 4 months ago (2014-08-18 18:07:49 UTC) #3
davidben
The CQ bit was unchecked by davidben@chromium.org
6 years, 4 months ago (2014-08-18 18:07:52 UTC) #4
davidben
+benm for android_webview OWNERS.
6 years, 4 months ago (2014-08-18 18:08:47 UTC) #5
davidben
benm: friendly ping
6 years, 4 months ago (2014-08-20 23:17:25 UTC) #6
benm (inactive)
lgtm sorry for the delay
6 years, 4 months ago (2014-08-21 11:28:14 UTC) #7
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 4 months ago (2014-08-21 15:35:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/481593002/60001
6 years, 4 months ago (2014-08-21 15:39:09 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 16:47:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (60001) as 291098

Powered by Google App Engine
This is Rietveld 408576698