content/browser/loader/resource_dispatcher_host_impl.cc - Issue 481593002: Remove child/route parameters from ShouldBeginRequest and RequestBeginning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 481593002: Remove child/route parameters from ShouldBeginRequest and RequestBeginning. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: android build Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/cross_site_transfer_browsertest.cc ('k') | content/browser/loader/resource_dispatcher_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index 3b66397793ba477d9a3831377ff7967635598651..664bf613633820103ce9564be9858c917a456920 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -999,9 +999,7 @@ void ResourceDispatcherHostImpl::BeginRequest(

}

// Allow the observer to block/handle the request.

- if (delegate_ && !delegate_->ShouldBeginRequest(child_id,

- route_id,

- request_data.method,

+ if (delegate_ && !delegate_->ShouldBeginRequest(request_data.method,

request_data.url,

request_data.resource_type,

resource_context)) {

@@ -1179,8 +1177,6 @@ scoped_ptr<ResourceHandler> ResourceDispatcherHostImpl::CreateResourceHandler(

resource_context,

filter_->appcache_service(),

request_data.resource_type,

- child_id,

- route_id,

&throttles);

}

« no previous file with comments | « content/browser/cross_site_transfer_browsertest.cc ('k') | content/browser/loader/resource_dispatcher_host_unittest.cc » ('j') | no next file with comments »