Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 481513004: Define NDEBUG instead of SK_DEBUG/SK_RELEASE. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Define NDEBUG instead of SK_DEBUG/SK_RELEASE. This makes our builds more like Chrome's, and will make our builds fail if we accidentally use if SK_DEBUG instead of ifdef SK_DEBUG. BUG=skia: Committed: https://skia.googlesource.com/skia/+/753b870c62bd22cee3d9a15efc634822724084ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -31 lines) Patch
M bench/nanobench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/Intersection/CubicIntersection_Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/Intersection/CubicUtilities.h View 1 chunk +1 line, -1 line 0 comments Download
M experimental/Intersection/CubicUtilities.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M experimental/Intersection/DataTypes.h View 1 chunk +1 line, -1 line 0 comments Download
M experimental/Intersection/DataTypes.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M experimental/Intersection/Intersections.h View 4 chunks +5 lines, -5 lines 0 comments Download
M experimental/Intersection/QuadraticImplicit.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M experimental/Intersection/QuarticRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/common.gypi View 1 chunk +3 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-20 13:35:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/481513004/1
6 years, 4 months ago (2014-08-20 13:36:01 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-20 13:36:01 UTC) #3
mtklein
6 years, 4 months ago (2014-08-20 13:52:30 UTC) #4
reed1
lgtm
6 years, 4 months ago (2014-08-20 14:36:49 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 14:38:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 753b870c62bd22cee3d9a15efc634822724084ac

Powered by Google App Engine
This is Rietveld 408576698