Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: gyp/common.gypi

Issue 481513004: Define NDEBUG instead of SK_DEBUG/SK_RELEASE. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « experimental/Intersection/QuarticRoot.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common.gypi
diff --git a/gyp/common.gypi b/gyp/common.gypi
index 14a541912b3427ac2ddcb854eaf84bb796c3239d..2d3fddd47d61f553c1657fc512708e78ffaae521 100644
--- a/gyp/common.gypi
+++ b/gyp/common.gypi
@@ -92,22 +92,11 @@
# one makefile and allow someone to add SK_DEBUG etc for their own
# debugging purposes.
'configurations': {
- 'Debug': {
- 'defines': [
- 'SK_DEBUG',
- 'SK_DEVELOPER=1',
- ],
- },
- 'Release': {
- 'defines': [
- 'SK_RELEASE',
- ],
- },
+ 'Debug': { 'defines': [ 'SK_DEVELOPER=1' ] },
+ 'Release': { 'defines': [ 'NDEBUG' ] },
'Release_Developer': {
'inherit_from': ['Release'],
- 'defines': [
- 'SK_DEVELOPER=1',
- ],
+ 'defines': [ 'SK_DEVELOPER=1' ],
},
},
}],
« no previous file with comments | « experimental/Intersection/QuarticRoot.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698