Chromium Code Reviews

Issue 481453003: Add FontFaceDescriptors IDL dictionary (Closed)

Created:
6 years, 4 months ago by bashi
Modified:
6 years, 3 months ago
Reviewers:
haraken, Kunihiko Sakamoto
CC:
blink-reviews, arv+blink, blink-reviews-css, ed+blinkwatch_opera.com, abarth-chromium, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, darktears, apavlov+blink_chromium.org, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@idl_gyp
Project:
blink
Visibility:
Public.

Description

Add FontFaceDescriptors IDL dictionary To follow the spec[1]. This is the first place to use IDL dictionary execept for testing, so this CL also includes build related changes. Existing tests(e.g. fast/css/fontface-constructor-error.html) should cover this change. [1] http://dev.w3.org/csswg/css-font-loading/#fontface-interface BUG=403150 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181610

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Stats (+67 lines, -56 lines)
M Source/bindings/core/idl.gni View 2 chunks +6 lines, -2 lines 0 comments
M Source/bindings/core/idl.gypi View 3 chunks +8 lines, -4 lines 0 comments
M Source/bindings/core/v8/BUILD.gn View 2 chunks +4 lines, -7 lines 0 comments
M Source/bindings/core/v8/generated.gyp View 2 chunks +2 lines, -4 lines 0 comments
M Source/core/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments
M Source/core/core.gni View 2 chunks +4 lines, -0 lines 0 comments
M Source/core/core.gyp View 1 chunk +1 line, -2 lines 0 comments
M Source/core/core.gypi View 1 chunk +7 lines, -12 lines 0 comments
M Source/core/css/FontFace.h View 3 chunks +5 lines, -4 lines 0 comments
M Source/core/css/FontFace.cpp View 5 chunks +11 lines, -18 lines 0 comments
M Source/core/css/FontFace.idl View 1 chunk +3 lines, -3 lines 0 comments
A Source/core/css/FontFaceDescriptors.idl View 1 chunk +14 lines, -0 lines 0 comments

Messages

Total messages: 9 (1 generated)
bashi
bashi@chromium.org changed reviewers: + haraken@chromium.org, ksakamoto@chromium.org
6 years, 3 months ago (2014-08-29 07:49:04 UTC) #1
bashi
Haraken-san, Could you review bindings and GYP/GN stuff? (GN changes is trivial, I think). Sakamoto-san, ...
6 years, 3 months ago (2014-08-29 07:49:04 UTC) #2
Kunihiko Sakamoto
core/css LGTM
6 years, 3 months ago (2014-08-29 08:01:48 UTC) #3
haraken
LGTM! https://codereview.chromium.org/481453003/diff/40001/Source/bindings/core/idl.gypi File Source/bindings/core/idl.gypi (right): https://codereview.chromium.org/481453003/diff/40001/Source/bindings/core/idl.gypi#newcode70 Source/bindings/core/idl.gypi:70: '<@(webcore_testing_dependency_idl_files)', Nit: Not related to this CL, we ...
6 years, 3 months ago (2014-08-29 08:01:59 UTC) #4
bashi
Now a bug in IDL dictionary implementation was fixed (https://codereview.chromium.org/554893004). I'm going to land this ...
6 years, 3 months ago (2014-09-09 05:09:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/481453003/60001
6 years, 3 months ago (2014-09-09 05:10:08 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 181610
6 years, 3 months ago (2014-09-09 06:11:42 UTC) #8
keishi
6 years, 3 months ago (2014-09-09 06:40:40 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/551873004/ by keishi@chromium.org.

The reason for reverting is: Broke build

http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/buil....

Powered by Google App Engine