Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 481403002: DevTools: move tracing based Timeline out of experiment (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 2 months ago
Reviewers:
caseq, alph, pfeldman, loislo
CC:
blink-reviews, shans, apavlov+blink_chromium.org, rjwright, Steve Block, caseq+blink_chromium.org, aandrey+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, blink-reviews-animation_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), sergeyv+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: move tracing based Timeline out of experiment Layout tests have been updated to work with the new backend and some of them have been deleted as there are already counterparts under inspector/timeline/tracing. BUG=398785, 399531

Patch Set 1 #

Patch Set 2 : Updated tests #

Patch Set 3 : Updated timeline-time.html test #

Patch Set 4 : Updated expectations for three tests under http/tests/inspector/ #

Patch Set 5 : Updated virtual/implsidepainting/inspector/timeline/timeline-paint-expected.txt #

Total comments: 4

Patch Set 6 : Updated inspector/timeline/timeline-coalescing.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+886 lines, -1138 lines) Patch
M LayoutTests/FlakyTests View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/SlowTests View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/timeline-test.js View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/timeline-xhr-event-expected.txt View 1 2 3 4 chunks +18 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/timeline-xhr-response-type-blob-event-expected.txt View 1 2 3 4 chunks +18 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/websocket/timeline-websocket-event-expected.txt View 1 2 3 4 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/category-filter.html View 1 1 chunk +29 lines, -9 lines 0 comments Download
M LayoutTests/inspector/timeline/resources/timeline-data.js View 1 chunk +454 lines, -175 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-animation-frame-expected.txt View 3 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-auto-record.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-auto-record-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-coalescing.html View 1 2 3 4 5 1 chunk +73 lines, -46 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-coalescing-expected.txt View 1 2 3 4 5 1 chunk +17 lines, -16 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-compatibility.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-compatibility-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-decode-resize.html View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-decode-resize-expected.txt View 1 chunk +0 lines, -88 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-dfs.html View 1 1 chunk +38 lines, -22 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-event-dispatch-expected.txt View 1 chunk +40 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-filtering.html View 1 2 chunks +45 lines, -31 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-flame-chart-automatically-size-window.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-flame-chart-automatically-size-window-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-frame-model.html View 1 chunk +0 lines, -202 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-frame-model-expected.txt View 1 chunk +0 lines, -226 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-injected-script-eval-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-layer-tree-snapshot.html View 1 chunk +0 lines, -80 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-layer-tree-snapshot-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-layout-expected.txt View 2 chunks +20 lines, -12 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-load-event-expected.txt View 2 chunks +2 lines, -22 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-mark-timeline-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-network-resource-expected.txt View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-paint-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-parse-html-expected.txt View 2 chunks +8 lines, -4 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-recalculate-styles-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-script-tag-1-expected.txt View 2 chunks +6 lines, -2 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-script-tag-2-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-time.html View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-time-expected.txt View 1 2 1 chunk +27 lines, -8 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-time-stamp-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-timer-expected.txt View 11 chunks +11 lines, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-window-filter-expected.txt View 1 chunk +22 lines, -22 lines 0 comments Download
M LayoutTests/virtual/implsidepainting/inspector/timeline/timeline-paint-expected.txt View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/common/Settings.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 4 chunks +12 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yurys
6 years, 4 months ago (2014-08-20 09:27:52 UTC) #1
yurys
ptal
6 years, 4 months ago (2014-08-21 13:02:41 UTC) #2
alph
lgtm https://codereview.chromium.org/481403002/diff/80001/LayoutTests/inspector/timeline/timeline-coalescing-expected.txt File LayoutTests/inspector/timeline/timeline-coalescing-expected.txt (right): https://codereview.chromium.org/481403002/diff/80001/LayoutTests/inspector/timeline/timeline-coalescing-expected.txt#newcode26 LayoutTests/inspector/timeline/timeline-coalescing-expected.txt:26: coalesced record's childHasWarnings(): undefined shouldn't it be true/false? ...
6 years, 4 months ago (2014-08-21 13:13:40 UTC) #3
yurys
https://codereview.chromium.org/481403002/diff/80001/LayoutTests/inspector/timeline/timeline-coalescing-expected.txt File LayoutTests/inspector/timeline/timeline-coalescing-expected.txt (right): https://codereview.chromium.org/481403002/diff/80001/LayoutTests/inspector/timeline/timeline-coalescing-expected.txt#newcode26 LayoutTests/inspector/timeline/timeline-coalescing-expected.txt:26: coalesced record's childHasWarnings(): undefined On 2014/08/21 13:13:39, alph wrote: ...
6 years, 4 months ago (2014-08-21 14:18:42 UTC) #4
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-21 14:18:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/481403002/100001
6 years, 4 months ago (2014-08-21 14:20:31 UTC) #6
yurys
The CQ bit was unchecked by yurys@chromium.org
6 years, 4 months ago (2014-08-21 14:46:24 UTC) #7
yurys
6 years, 4 months ago (2014-08-21 14:51:50 UTC) #8
In offline discussion we decided to break this in several steps:
1. Copy new version of existing timeline tests into separate folder so that they
are executed with tracing based implementation while old tests continue to run
with the old timeline implementation.
2. Replace "Timeline on trace events" experiment with "Old Timeline" or
something so that tracing based Timeline is used by default.
3. Collect feedback in a couple of dev channel releases and if everything goes
well remove the experiment along with the old Timeline code.

Powered by Google App Engine
This is Rietveld 408576698