pkg/analysis_server/test/services/refactoring/abstract_rename.dart - Issue 481173002: When user renames 'prefix' in 'prefix.Class' she actually wants to rename ImportElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/refactoring/abstract_rename.dart

Issue 481173002: When user renames 'prefix' in 'prefix.Class' she actually wants to rename ImportElement. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Tweak for test - reference ambiguous prefix name. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/edit/refactoring_test.dart ('k') | pkg/analysis_server/test/services/refactoring/rename_import_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/refactoring/abstract_rename.dart

diff --git a/pkg/analysis_server/test/services/refactoring/abstract_rename.dart b/pkg/analysis_server/test/services/refactoring/abstract_rename.dart

index 57bebd0870704c28899bcf1ca177596038846993..228656fc10a6254b311b9cbdb41e4edaea6f5d62 100644

--- a/pkg/analysis_server/test/services/refactoring/abstract_rename.dart

+++ b/pkg/analysis_server/test/services/refactoring/abstract_rename.dart

@@ -7,6 +7,7 @@ library test.services.refactoring.rename;

import 'dart:async';

import 'package:analysis_server/src/services/correction/change.dart';

+import 'package:analysis_server/src/services/correction/namespace.dart';

import 'package:analysis_server/src/services/refactoring/refactoring.dart';

import 'package:analyzer/file_system/file_system.dart';

import 'package:analyzer/src/generated/ast.dart';

@@ -101,10 +102,9 @@ class RenameRefactoringTest extends RefactoringTest {

void createRenameRefactoringAtString(String search) {

SimpleIdentifier identifier = findIdentifier(search);

Element element = identifier.bestElement;

- // TODO(scheglov) uncomment later

-// if (element instanceof PrefixElement) {

-// element = IndexContributor.getImportElement(identifier);

-// }

+ if (element is PrefixElement) {

+ element = getImportElement(identifier);

+ }

createRenameRefactoringForElement(element);

}