Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Side by Side Diff: pkg/analysis_server/test/services/refactoring/abstract_rename.dart

Issue 481173002: When user renames 'prefix' in 'prefix.Class' she actually wants to rename ImportElement. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Tweak for test - reference ambiguous prefix name. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.services.refactoring.rename; 5 library test.services.refactoring.rename;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_server/src/services/correction/change.dart'; 9 import 'package:analysis_server/src/services/correction/change.dart';
10 import 'package:analysis_server/src/services/correction/namespace.dart';
10 import 'package:analysis_server/src/services/refactoring/refactoring.dart'; 11 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
11 import 'package:analyzer/file_system/file_system.dart'; 12 import 'package:analyzer/file_system/file_system.dart';
12 import 'package:analyzer/src/generated/ast.dart'; 13 import 'package:analyzer/src/generated/ast.dart';
13 import 'package:analyzer/src/generated/element.dart'; 14 import 'package:analyzer/src/generated/element.dart';
14 import 'package:analyzer/src/generated/source.dart'; 15 import 'package:analyzer/src/generated/source.dart';
15 import 'package:unittest/unittest.dart'; 16 import 'package:unittest/unittest.dart';
16 17
17 import 'abstract_refactoring.dart'; 18 import 'abstract_refactoring.dart';
18 19
19 20
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 expect(actualCode, expectedCode); 95 expect(actualCode, expectedCode);
95 } 96 }
96 97
97 /** 98 /**
98 * Creates a new [RenameRefactoring] in [refactoring] for the [Element] of 99 * Creates a new [RenameRefactoring] in [refactoring] for the [Element] of
99 * the [SimpleIdentifier] at the given [search] pattern. 100 * the [SimpleIdentifier] at the given [search] pattern.
100 */ 101 */
101 void createRenameRefactoringAtString(String search) { 102 void createRenameRefactoringAtString(String search) {
102 SimpleIdentifier identifier = findIdentifier(search); 103 SimpleIdentifier identifier = findIdentifier(search);
103 Element element = identifier.bestElement; 104 Element element = identifier.bestElement;
104 // TODO(scheglov) uncomment later 105 if (element is PrefixElement) {
105 // if (element instanceof PrefixElement) { 106 element = getImportElement(identifier);
106 // element = IndexContributor.getImportElement(identifier); 107 }
107 // }
108 createRenameRefactoringForElement(element); 108 createRenameRefactoringForElement(element);
109 } 109 }
110 110
111 /** 111 /**
112 * Creates a new [RenameRefactoring] in [refactoring] for [element]. 112 * Creates a new [RenameRefactoring] in [refactoring] for [element].
113 * Fails if no [RenameRefactoring] can be created. 113 * Fails if no [RenameRefactoring] can be created.
114 */ 114 */
115 void createRenameRefactoringForElement(Element element) { 115 void createRenameRefactoringForElement(Element element) {
116 refactoring = new RenameRefactoring(searchEngine, element); 116 refactoring = new RenameRefactoring(searchEngine, element);
117 expect(refactoring, isNotNull, reason: "No refactoring for '$element'."); 117 expect(refactoring, isNotNull, reason: "No refactoring for '$element'.");
(...skipping 27 matching lines...) Expand all
145 // void assertChangeResult(Change change, Source source, String expected) 145 // void assertChangeResult(Change change, Source source, String expected)
146 // { 146 // {
147 // SourceChange sourceChange = getSourceChange(compositeChange, source); 147 // SourceChange sourceChange = getSourceChange(compositeChange, source);
148 // assertNotNull("No change for: " + source.toString(), sourceChange); 148 // assertNotNull("No change for: " + source.toString(), sourceChange);
149 // String sourceResult = getChangeResult(context, source, sourceChange); 149 // String sourceResult = getChangeResult(context, source, sourceChange);
150 // assertEquals(expected, sourceResult); 150 // assertEquals(expected, sourceResult);
151 //// AnalysisContext context = getAnalysisContext(); 151 //// AnalysisContext context = getAnalysisContext();
152 //// assertChangeResult(context, compositeChange, source, expected); 152 //// assertChangeResult(context, compositeChange, source, expected);
153 // } 153 // }
154 } 154 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698