Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Unified Diff: Source/core/loader/TextTrackLoader.h

Issue 48113029: Use a TextTrackLoaderClient reference (not pointer) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@rmTextTrackResource
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/LoadableTextTrack.cpp ('k') | Source/core/loader/TextTrackLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/TextTrackLoader.h
diff --git a/Source/core/loader/TextTrackLoader.h b/Source/core/loader/TextTrackLoader.h
index 2dd1cb35a35ca161e2bee20b1967a234311e2c9b..451ef79173981b282b28462e4c1a55e9c1a68e6d 100644
--- a/Source/core/loader/TextTrackLoader.h
+++ b/Source/core/loader/TextTrackLoader.h
@@ -52,7 +52,7 @@ class TextTrackLoader : public RawResourceClient, private WebVTTParserClient {
WTF_MAKE_NONCOPYABLE(TextTrackLoader);
WTF_MAKE_FAST_ALLOCATED;
public:
- static PassOwnPtr<TextTrackLoader> create(TextTrackLoaderClient* client, Document& document)
+ static PassOwnPtr<TextTrackLoader> create(TextTrackLoaderClient& client, Document& document)
{
return adoptPtr(new TextTrackLoader(client, document));
}
@@ -77,12 +77,12 @@ private:
virtual void newRegionsParsed() OVERRIDE;
virtual void fileFailedToParse() OVERRIDE;
- TextTrackLoader(TextTrackLoaderClient*, Document&);
+ TextTrackLoader(TextTrackLoaderClient&, Document&);
void cueLoadTimerFired(Timer<TextTrackLoader>*);
void corsPolicyPreventedLoad();
- TextTrackLoaderClient* m_client;
+ TextTrackLoaderClient& m_client;
OwnPtr<WebVTTParser> m_cueParser;
ResourcePtr<RawResource> m_resource;
// FIXME: Remove this pointer and get the Document from m_client.
« no previous file with comments | « Source/core/html/track/LoadableTextTrack.cpp ('k') | Source/core/loader/TextTrackLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698